Skip to content

Conversation

@ih-codes
Copy link
Collaborator

@ih-codes ih-codes commented Dec 1, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Fix setUp/tearDown warnings in the XCUITests suite by using the async throws version of the methods
  • Fix main actor isolation warnings for some local state with @MainActor

See the Swift 6 Migration channel (#tmp-swift-6-migration) for details on how to migrate the setUp and tearDown methods.

Batch 1: #31025

cc @Cramsden @lmarceau @dataports

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@ih-codes ih-codes requested a review from clarmso December 1, 2025 20:10
@ih-codes ih-codes requested a review from a team as a code owner December 1, 2025 20:10
@ih-codes ih-codes force-pushed the ih/FXIOS-12796-XCUITests-batch-2 branch from e408990 to 0c756a6 Compare December 1, 2025 20:11
@clarmso
Copy link
Collaborator

clarmso commented Dec 1, 2025

@mdotb-moz FYI: Some Swift 6 warnings have been on the POM. I will follow up with the developers.

@mobiletest-ci-bot
Copy link

💪 Quality guardian

51 tests files modified. You're a champion of test coverage! 🚀

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 70a97c6

@ih-codes ih-codes merged commit d88df08 into main Dec 5, 2025
9 checks passed
@ih-codes ih-codes deleted the ih/FXIOS-12796-XCUITests-batch-2 branch December 5, 2025 21:09
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🚀 PR merged to main, targeting version: 147.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants