Merged
Conversation
susnux
added
3. to review
susnux
force-pushed
the
refactor/NcXField-ts
branch
2 times, most recently
from
d121b03 to
bbfcbf6
Compare
ShGKme
reviewed
May 26, 2025
susnux
force-pushed
the
refactor/NcXField-ts
branch
from
dd5cdda to
7949d9d
Compare
susnux
force-pushed
the
refactor/NcXField-ts
branch
from
7949d9d to
b572632
Compare
ShGKme
approved these changes
Jun 2, 2025
Antreesy
approved these changes
Jun 2, 2025
| /** | ||
| * Specifies which material design icon should be used for the trailing button. | ||
| */ | ||
| trailingButtonIcon?: 'close' | 'arrowRight' | 'undo' |
Contributor
There was a problem hiding this comment.
migrate to svg wrapper? arrowRight should be directional, I supppose
Contributor
Author
There was a problem hiding this comment.
Yes but thats more than a refactor, will do in a follow up
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…-setup Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/NcXField-ts
branch
from
d912642 to
dc014e4
Compare
Contributor
Author
|
Squashed fixups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This 3 components make sense to keep aligned so I decided to do it in 1 PR with different commits.
So it makes sense to review each commit separately.
Also added tests to ensure we do not break working behavior.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable