Skip to content

fix(NcTextField): helper text icon is too large#7856

Merged
susnux merged 2 commits intomainfrom
fix/input--icon-inline
Nov 13, 2025
Merged

fix(NcTextField): helper text icon is too large#7856
susnux merged 2 commits intomainfrom
fix/input--icon-inline

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 13, 2025

☑️ Resolves

🖼️ Screenshots

Stable8 Before After
image image image
image image image
image image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 9.3.0 milestone Nov 13, 2025
@ShGKme ShGKme self-assigned this Nov 13, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.78%. Comparing base (eac1b94) to head (2676e87).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcInputField/NcInputField.vue 66.66% 1 Missing ⚠️
src/components/NcTextArea/NcTextArea.vue 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7856      +/-   ##
==========================================
+ Coverage   51.75%   51.78%   +0.03%     
==========================================
  Files          98       98              
  Lines        3169     3171       +2     
  Branches      871      874       +3     
==========================================
+ Hits         1640     1642       +2     
  Misses       1279     1279              
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme marked this pull request as draft November 13, 2025 15:38
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/input--icon-inline branch from db95816 to 2676e87 Compare November 13, 2025 16:09
@ShGKme ShGKme marked this pull request as ready for review November 13, 2025 16:13
@susnux susnux merged commit 9c1cc6e into main Nov 13, 2025
29 checks passed
@susnux susnux deleted the fix/input--icon-inline branch November 13, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants