fix(NcActions): handle expensive height computation by popover library#7778
fix(NcActions): handle expensive height computation by popover library#7778
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7778 +/- ##
==========================================
+ Coverage 51.41% 51.75% +0.34%
==========================================
Files 96 96
Lines 3147 3126 -21
Branches 867 863 -4
==========================================
Hits 1618 1618
+ Misses 1279 1262 -17
+ Partials 250 246 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9456615 to
42a6e84
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
So while it now takes full height, it looses the main reason for the manual resizing: So codewise I am fine, but just needs approval of @jancborchardt (added that feature). |
This comment was marked as resolved.
This comment was marked as resolved.
Drawback would be then only for browsers, who don't show the scrollbar by default, right? |
- `autoBoundaryMaxSize` lets floating vue resize the popper inner container to the available size Signed-off-by: Maksim Sukharev <[email protected]>
42a6e84 to
b95e84b
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Really nice improvement so I’d approve. :) We can check later if there is adjustment needed for cutting of at 1/2 of entries, or if that’s an issue at all (probably depending on system and scrollbar visibility).
|
Isnt this solved by #7808 ? |
Performance - mostly solved. |
susnux
left a comment
There was a problem hiding this comment.
code makes sense and so as design agrees this is fine :)
|
@Antreesy backport? |
|
/backport to stable8 |
☑️ Resolves
autoBoundaryMaxSizelets floating vue resize the popper inner container to the available size🖼️ Screenshots
🏚️ Before
2025-11-05_11h22_00.mp4
🏡 After
2025-11-05_11h17_43.mp4
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable