Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 7, 2025

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.2.0 milestone Nov 7, 2025
@Antreesy Antreesy requested review from ShGKme and susnux November 7, 2025 11:29
@Antreesy Antreesy self-assigned this Nov 7, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews feature: actions Related to the actions components labels Nov 7, 2025
@Antreesy Antreesy force-pushed the fix/noid/nc-actions-performance-v2 branch from 986d126 to 726acfd Compare November 7, 2025 11:29
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.41%. Comparing base (eaf4a03) to head (726acfd).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcActions/NcActions.vue 12.50% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7808      +/-   ##
==========================================
- Coverage   51.58%   51.41%   -0.18%     
==========================================
  Files          96       96              
  Lines        3148     3147       -1     
  Branches      865      868       +3     
==========================================
- Hits         1624     1618       -6     
- Misses       1276     1279       +3     
- Partials      248      250       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@ShGKme ShGKme requested a review from DorraJaouad November 7, 2025 13:02
@susnux susnux merged commit 40a0850 into main Nov 7, 2025
25 of 27 checks passed
@susnux susnux deleted the fix/noid/nc-actions-performance-v2 branch November 7, 2025 13:34
@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 7, 2025

/backport to stable8

@ShGKme ShGKme added the bug Something isn't working label Nov 7, 2025
@ShGKme ShGKme changed the title fix(NcActions): only compute popover maxHeight on demand fix(NcActions): improve performance by only computing popover maxHeight on demand Nov 7, 2025
@ShGKme ShGKme mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants