Skip to content

[stable8] fix(NcActions): improve performance by only computing popover maxHeight on demand#7815

Merged
ShGKme merged 1 commit intostable8from
backport/7808/stable8
Nov 7, 2025
Merged

[stable8] fix(NcActions): improve performance by only computing popover maxHeight on demand#7815
ShGKme merged 1 commit intostable8from
backport/7808/stable8

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 7, 2025

Backport of #7808

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux November 7, 2025 13:38
@backportbot backportbot bot added 3. to review Waiting for reviews feature: actions Related to the actions components labels Nov 7, 2025
@backportbot backportbot bot added this to the 8.34.0 milestone Nov 7, 2025
@Antreesy Antreesy force-pushed the backport/7808/stable8 branch from 42cd71c to 5e06367 Compare November 7, 2025 13:57
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept triggerRandomId as it's used differently from Vue 3 branch

@Antreesy Antreesy marked this pull request as ready for review November 7, 2025 13:59
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.62%. Comparing base (47e8775) to head (5e06367).
⚠️ Report is 6 commits behind head on stable8.

Additional details and impacted files
@@           Coverage Diff            @@
##           stable8    #7815   +/-   ##
========================================
  Coverage    44.62%   44.62%           
========================================
  Files          188      188           
  Lines         4710     4710           
  Branches      1226     1226           
========================================
  Hits          2102     2102           
  Misses        2513     2513           
  Partials        95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme merged commit fc87998 into stable8 Nov 7, 2025
21 of 23 checks passed
@ShGKme ShGKme deleted the backport/7808/stable8 branch November 7, 2025 14:42
@ShGKme ShGKme added the bug Something isn't working label Nov 7, 2025
@ShGKme ShGKme changed the title [stable8] fix(NcActions): only compute popover maxHeight on demand [stable8] fix(NcActions): improve performance by only computing popover maxHeight on demand Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants