Skip to content

feat(NcRichText): add 'Copy to clipboard' button for code blocks#7841

Merged
Antreesy merged 3 commits intomainfrom
feat/noid/rich-text-copy-code
Nov 17, 2025
Merged

feat(NcRichText): add 'Copy to clipboard' button for code blocks#7841
Antreesy merged 3 commits intomainfrom
feat/noid/rich-text-copy-code

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 11, 2025

β˜‘οΈ Resolves

  • Attempt to upstream clipboard functionality from Talk
  • Logic based on NcFormBoxCopyButton
  • Works with plain text and highlighted syntax

πŸ–ΌοΈ Screenshots

🏑 After
image

🚧 Tasks

  • Move useCopy to composables?
  • Extract CopyButton as standalone component?
  • Need a prop to enable/disable?

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.3.0 milestone Nov 11, 2025
@Antreesy Antreesy self-assigned this Nov 11, 2025
@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 52.11%. Comparing base (6523151) to head (9cf7ad7).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7841      +/-   ##
==========================================
- Coverage   52.12%   52.11%   -0.02%     
==========================================
  Files          98      100       +2     
  Lines        3150     3170      +20     
  Branches      869      873       +4     
==========================================
+ Hits         1642     1652      +10     
- Misses       1262     1271       +9     
- Partials      246      247       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy force-pushed the feat/noid/rich-text-copy-code branch from f0903ad to a0d2890 Compare November 11, 2025 14:57
@Antreesy Antreesy requested a review from ShGKme November 11, 2025 14:59
@Antreesy Antreesy force-pushed the feat/noid/rich-text-copy-code branch 2 times, most recently from b7ac6d8 to 9795919 Compare November 13, 2025 08:48
@Antreesy Antreesy force-pushed the feat/noid/rich-text-copy-code branch from 9795919 to ffaaa29 Compare November 13, 2025 11:07
@Antreesy Antreesy force-pushed the feat/noid/rich-text-copy-code branch from ffaaa29 to 9cf7ad7 Compare November 17, 2025 12:59
@Antreesy
Copy link
Contributor Author

/backport to stable8

@Antreesy Antreesy merged commit 8e6c2a6 into main Nov 17, 2025
26 of 27 checks passed
@Antreesy Antreesy deleted the feat/noid/rich-text-copy-code branch November 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants