Skip to content

[stable8] feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it #7850

Merged
ShGKme merged 1 commit intostable8from
backport/7837/stable8
Nov 13, 2025
Merged

[stable8] feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it #7850
ShGKme merged 1 commit intostable8from
backport/7837/stable8

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 12, 2025

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 8.35.0 milestone Nov 12, 2025
@ShGKme ShGKme requested review from Antreesy, kra-mo and susnux November 12, 2025 18:01
@ShGKme ShGKme self-assigned this Nov 12, 2025
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Nov 12, 2025
@ShGKme ShGKme changed the title [stable8] feat(NcAppSettingsDialog): add version on the bottom [stable8] feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.08%. Comparing base (242f14f) to head (90656bc).
⚠️ Report is 10 commits behind head on stable8.

Files with missing lines Patch % Lines
src/utils/appName.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7850      +/-   ##
===========================================
+ Coverage    44.61%   45.08%   +0.46%     
===========================================
  Files          188      191       +3     
  Lines         4711     4749      +38     
  Branches      1226     1169      -57     
===========================================
+ Hits          2102     2141      +39     
  Misses        2514     2514              
+ Partials        95       94       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme merged commit d232503 into stable8 Nov 13, 2025
19 of 21 checks passed
@ShGKme ShGKme deleted the backport/7837/stable8 branch November 13, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants