Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7837 +/- ##
==========================================
+ Coverage 51.46% 51.72% +0.26%
==========================================
Files 96 98 +2
Lines 3150 3167 +17
Branches 870 872 +2
==========================================
+ Hits 1621 1638 +17
Misses 1279 1279
Partials 250 250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/components/NcAppSettingsDialog/NcAppSettingsDialogVersion.vue
Outdated
Show resolved
Hide resolved
src/components/NcAppSettingsDialog/NcAppSettingsDialogVersion.vue
Outdated
Show resolved
Hide resolved
noVersion prop to disable it
kra-mo
left a comment
There was a problem hiding this comment.
Looks nice.
Only question is where do we put it after the redesign which only shows one section at a time. The two most obvious options are:
- In the sidebar (and at the bottom as it is now when there is only one section and no sidebar is visible).
- Always at the end of the last section. This could be confusing to access but maybe not a real problem if we rename "Keyboard shortcuts" to "Help" or something like that.
Makes sense. |
I'd put it to the navigation, yes. |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
5688c59 to
7b8a89e
Compare
|
|
/backport to stable8 |
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/7837/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b8a89e9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7837/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
☑️ Resolves
{Title} version {number}is grammatically easily translatable in all the languages).🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable