Skip to content

feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it#7837

Merged
ShGKme merged 1 commit intomainfrom
feat/NcAppSettingsDialog--version
Nov 12, 2025
Merged

feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it#7837
ShGKme merged 1 commit intomainfrom
feat/NcAppSettingsDialog--version

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 10, 2025

☑️ Resolves

  • Ref: Overview: Settings reorganization nextcloud/server#55667
  • I missed that it was also a part of the design
  • ⚠️ I've removed the "version" part to remove a requirement to have a new translated string and simplify it for translations (I'm unsure {Title} version {number} is grammatically easily translatable in all the languages).

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme self-assigned this Nov 10, 2025
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.72%. Comparing base (4a3a085) to head (7b8a89e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7837      +/-   ##
==========================================
+ Coverage   51.46%   51.72%   +0.26%     
==========================================
  Files          96       98       +2     
  Lines        3150     3167      +17     
  Branches      870      872       +2     
==========================================
+ Hits         1621     1638      +17     
  Misses       1279     1279              
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme changed the title feat(NcAppSettingsDialog): add version on the bottom feat(NcAppSettingsDialog): add version on the bottom and noVersion prop to disable it Nov 10, 2025
@ShGKme ShGKme added this to the 9.3.0 milestone Nov 10, 2025
@ShGKme ShGKme requested a review from kra-mo November 10, 2025 19:55
@ShGKme ShGKme requested a review from DorraJaouad November 11, 2025 14:13
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

Only question is where do we put it after the redesign which only shows one section at a time. The two most obvious options are:

  1. In the sidebar (and at the bottom as it is now when there is only one section and no sidebar is visible).
  2. Always at the end of the last section. This could be confusing to access but maybe not a real problem if we rename "Keyboard shortcuts" to "Help" or something like that.

@kra-mo
Copy link
Member

kra-mo commented Nov 11, 2025

⚠️ I've removed the "version" part to remove a requirement to have a new translated string and simplify it for translations (I'm unsure {Title} version {number} is grammatically easily translatable in all the languages).

Makes sense.

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 11, 2025

  1. In the sidebar (and at the bottom as it is now when there is only one section and no sidebar is visible).

I'd put it to the navigation, yes.

@ShGKme ShGKme force-pushed the feat/NcAppSettingsDialog--version branch from 5688c59 to 7b8a89e Compare November 12, 2025 17:26
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 12, 2025

  • Rebased and squashed

@ShGKme ShGKme enabled auto-merge November 12, 2025 17:26
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 12, 2025

/backport to stable8

@ShGKme ShGKme merged commit dd4ff45 into main Nov 12, 2025
27 checks passed
@ShGKme ShGKme deleted the feat/NcAppSettingsDialog--version branch November 12, 2025 17:29
@backportbot
Copy link

backportbot bot commented Nov 12, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7837/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b8a89e9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7837/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants