fix(NcActionCheckbox): margin around the checkbox#7890
Conversation
Signed-off-by: greta <gretadoci@gmail.com>
|
/backport to stable8 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
=======================================
Coverage 52.11% 52.11%
=======================================
Files 100 100
Lines 3170 3170
Branches 872 873 +1
=======================================
Hits 1652 1652
Misses 1271 1271
Partials 247 247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Antreesy
left a comment
There was a problem hiding this comment.
Is is still actual, or you fixed it already in Mail?
| &::before { | ||
| margin-block: 0 !important; | ||
| margin-inline: calc((var(--default-clickable-area) - 14px) / 2) !important; | ||
| margin: 9px !important; |
There was a problem hiding this comment.
This simply overriding two lines above. Doesn't it conflict with other usecases for component?
There was a problem hiding this comment.
it comes from here, so we should fix it here. I understand that 9px is very random, so maybe i can think about how not to have an exact number like that. Its broken everywhere where we use this component, at least everywhere on mail
|
Playing with margins to move server-styled icon having different Nextcloud versions seems complicated and unreliable. And the current icon design looks off anyway.
|
|
closing and continuing here #8020 |
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable