Skip to content

fix(NcActions): migrate to custom icons in Checkbox and Radio actions#8020

Merged
GretaD merged 1 commit intomainfrom
fix/NcActionCheckboxRadio
Jan 8, 2026
Merged

fix(NcActions): migrate to custom icons in Checkbox and Radio actions#8020
GretaD merged 1 commit intomainfrom
fix/NcActionCheckboxRadio

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 18, 2025

☑️ Resolves

  • Alternative to fix(NcActionCheckbox): margin around the checkbox #7890
  • Use the same icons as in NcCheckboxRadioSwitch instead of legacy server styles
  • Specify the focus visible outline.
  • Also simplify components a bit
  • Both components are very similar, but I don't want to reuse the code to not complicate existing NcActions set. Duplicated code is quite small and simple

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.4.0 milestone Dec 18, 2025
@ShGKme ShGKme requested review from Antreesy, GretaD and susnux December 18, 2025 15:26
@ShGKme ShGKme self-assigned this Dec 18, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Dec 18, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 18, 2025

/backport to stable8

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.25%. Comparing base (e125565) to head (7feb4ff).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8020   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files         101      101           
  Lines        3145     3145           
  Branches      872      872           
=======================================
  Hits         1675     1675           
  Misses       1232     1232           
  Partials      238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GretaD GretaD merged commit 824420e into main Jan 8, 2026
27 of 28 checks passed
@GretaD GretaD deleted the fix/NcActionCheckboxRadio branch January 8, 2026 18:44
@Antreesy Antreesy mentioned this pull request Jan 9, 2026
@ShGKme ShGKme modified the milestones: 9.4.0, 9.3.3 Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants