[stable8] fix(NcActions): migrate to custom icons in Checkbox and Radio actions#8060
Merged
[stable8] fix(NcActions): migrate to custom icons in Checkbox and Radio actions#8060
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
bf19b15 to
7d3eb04
Compare
ShGKme
approved these changes
Jan 8, 2026
ShGKme
reviewed
Jan 8, 2026
Comment on lines
+156
to
+159
| // For backward compatibility to support using without v-model binding (passive model) | ||
| const localModel = ref(model.value) | ||
| watch(model, (newValue) => (localModel.value = newValue), { flush: 'sync' }) | ||
| watch(localModel, (newValue) => (model.value = newValue), { flush: 'sync' }) |
Contributor
There was a problem hiding this comment.
The only notable change from Vue 3 version.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable8 #8060 +/- ##
===========================================
+ Coverage 45.54% 45.63% +0.08%
===========================================
Files 193 193
Lines 4797 4788 -9
Branches 1237 1173 -64
===========================================
Hits 2185 2185
+ Misses 2517 2510 -7
+ Partials 95 93 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8020
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.