Skip to content

[stable8] fix(useHotKey): do not prevent hotkeys on hidden modal/dialog#7971

Merged
skjnldsv merged 1 commit intostable8from
backport/7966/stable8
Dec 10, 2025
Merged

[stable8] fix(useHotKey): do not prevent hotkeys on hidden modal/dialog#7971
skjnldsv merged 1 commit intostable8from
backport/7966/stable8

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 10, 2025

@skjnldsv skjnldsv self-assigned this Dec 10, 2025
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component labels Dec 10, 2025
@skjnldsv skjnldsv force-pushed the backport/7966/stable8 branch 2 times, most recently from 2753020 to 4d928fb Compare December 10, 2025 10:25
@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv changed the title fix: do not prevent hotkeys on hidden modal/dialog [stable8 fix: do not prevent hotkeys on hidden modal/dialog Dec 10, 2025
@skjnldsv skjnldsv changed the title [stable8 fix: do not prevent hotkeys on hidden modal/dialog [stable8] fix: do not prevent hotkeys on hidden modal/dialog Dec 10, 2025
@skjnldsv skjnldsv force-pushed the backport/7966/stable8 branch from 6423430 to 4d928fb Compare December 10, 2025 10:42
@skjnldsv skjnldsv force-pushed the backport/7966/stable8 branch from 4d928fb to 823f014 Compare December 10, 2025 11:00
@ShGKme ShGKme changed the title [stable8] fix: do not prevent hotkeys on hidden modal/dialog [stable8] fix(useHotKey): do not prevent hotkeys on hidden modal/dialog Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.48%. Comparing base (1b828cc) to head (823f014).
⚠️ Report is 2 commits behind head on stable8.

Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #7971      +/-   ##
===========================================
+ Coverage    45.46%   45.48%   +0.01%     
===========================================
  Files          192      192              
  Lines         4768     4769       +1     
  Branches      1172     1230      +58     
===========================================
+ Hits          2168     2169       +1     
+ Misses        2508     2506       -2     
- Partials        92       94       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


afterEach(() => {
mockCallback.mockReset()
document.body.innerHTML = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safer to remove the created modal to make sure nothing else is removed by mistake (for example, if it is run in a Vitest web-browser environment or Playwright component tests)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use the same code as main to ensure no one else get confused like I was

@skjnldsv skjnldsv merged commit af0280f into stable8 Dec 10, 2025
19 of 21 checks passed
@skjnldsv skjnldsv deleted the backport/7966/stable8 branch December 10, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants