fix(useHotKey): do not prevent hotkeys on hidden modal/dialog#7966
fix(useHotKey): do not prevent hotkeys on hidden modal/dialog#7966
Conversation
|
I was a bit too quick, let me adjust the test |
511dbe2 to
3bb6356
Compare
3bb6356 to
a11c769
Compare
Signed-off-by: skjnldsv <[email protected]>
a11c769 to
fb0e3d6
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7966 +/- ##
==========================================
+ Coverage 52.99% 53.01% +0.01%
==========================================
Files 100 100
Lines 3119 3120 +1
Branches 867 868 +1
==========================================
+ Hits 1653 1654 +1
Misses 1228 1228
Partials 238 238 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
|
/backport to stable8 |
ShGKme
left a comment
There was a problem hiding this comment.
Fine for a hotfix, but I'd propose to remove allowInModal in favour of hotkey scoping similar to the focus trap.
So that:
- It doesn't depend on a CSS class in the modal
- It supports not only
NcModalbut other modal popovers as well likeNcPopover - It supports nesting, for example, when a file picker dialog is open from the settings dialog, and each has its own hotkeys
Referenced in new ticket π |
Antreesy
left a comment
There was a problem hiding this comment.
Otherwise works fine, smoke tested in the app
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/7966/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fb0e3d68
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7966/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport fb0e3d6 to stable8 |
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/7966/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fb0e3d6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7966/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Found working on Server upgrade. If the viewer is idling waiting to be shown, the element is still present in the dom.
We need to ensure it's also really shown.
π Checklist
stable8for maintained Vue 2 version or not applicable