Skip to content

chore: v9.3.1#7973

Merged
skjnldsv merged 1 commit intomainfrom
chore/v9.3.1
Dec 11, 2025
Merged

chore: v9.3.1#7973
skjnldsv merged 1 commit intomainfrom
chore/v9.3.1

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 10, 2025

v9.3.1 (2025-12-10)

Full Changelog

πŸš€ Enhancements

  • feat(useHotKey): add new option allowInModal #7514 (susnux)

πŸ› Fixed bugs

  • fix(NcFormBox): add NcButton to supported components #7886 (ShGKme)
  • fix: adjust input border styles for dark theme and NcSelect #7501 (susnux)
  • fix: logger is not defined #7944 (ShGKme)
  • fix(useHotKey): do not prevent hotkeys on hidden modal/dialog #7966 (skjnldsv)

Other Changes

  • refactor(NcModal): migrate to Typescript and script-setup #7514 (susnux)
  • chore(NcActions): outline icons in docs #7920 (ShGKme)
  • refactor: fix Typescript issues in build files #7922 (susnux)
  • refactor(useHotKey): modal visibility check using Array.from #7972 (skjnldsv)

@skjnldsv skjnldsv added this to the 9.3.1 milestone Dec 10, 2025
@skjnldsv skjnldsv self-assigned this Dec 10, 2025
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 53.25%. Comparing base (081c899) to head (9399159).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7973   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files         101      101           
  Lines        3145     3145           
  Branches      872      872           
=======================================
  Hits         1675     1675           
  Misses       1232     1232           
  Partials      238      238           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to reformat the changelog with the script

@skjnldsv skjnldsv requested a review from ShGKme December 10, 2025 11:15
@Antreesy

This comment was marked as resolved.

@ShGKme

This comment was marked as resolved.

@susnux
Copy link
Contributor

susnux commented Dec 10, 2025

Modal should be fixed with the recent merge of the scoping fix

@skjnldsv
Copy link
Contributor Author

@Antreesy @ShGKme sooo, merge or not ?

@ShGKme
Copy link
Contributor

ShGKme commented Dec 10, 2025

Rebase, adjust the change log, merge

Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv merged commit e241138 into main Dec 11, 2025
27 checks passed
@skjnldsv skjnldsv deleted the chore/v9.3.1 branch December 11, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants