Correctly check the reception of a remote feedback

[artonge]

On the creation of a federated share, the receiving server wrongly check the notification response which lead to sending a notification twice.

emitting server	receiving server
send share -->	_
_	--> receive share
_	--- user accept share
_	<-- send accepted_share notification
receive notification <---	-
_	--- check the result of the notification, it's an array and not true
_	<-- assume the request failed and send the notification to the legacy endpoint
receive duplicate notification <---	_

Here is an example of duplicate notification:

[MichaIng]

It looks like one test need to be changed:

1. OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
   Expectation failed for method name is "newClient" when invoked at sequence index 0.
   The expected invocation at index 0 was never reached.

testAddShare uses method newClient after acceptShare which calls the changed sendFeedbackToRemote. Not if or how this makes the test fail, but this is the only chain that I could find 😄.

[artonge]

testAddShare uses method newClient after acceptShare which calls the changed sendFeedbackToRemote. Not if or how this makes the test fail, but this is the only chain that I could find smile.

Thanks, I was on it, but I am not very familiar with phpunit, so this helps :)

[MichaIng]

Ah, a bid later declineShare is called, which also calls sendFeedbackToRemote of course. With this commit, this functions returns true in more cases, so the remote get's a positive feedback when the test expects a negative one? With such a long function and multiple same method calls, a little more verbosity of the test would be helpful, like a line number 😄.

OOT: For this test #27414 applies as well.