Conversation
1 task
Member
Author
|
this is mostly for nextcloud/user_migration#83 but I'm not too happy about the approach there the elephant in the room is that OC\Archive\Zip::getFiles() is called repeatedly for each call of |
come-nc
reviewed
Apr 11, 2022
PVince81
force-pushed
the
enh/noid/zip-expose-stat
branch
from
28f41e6 to
44fece6
Compare
come-nc
reviewed
Apr 11, 2022
PVince81
force-pushed
the
enh/noid/zip-expose-stat
branch
from
44fece6 to
62b6297
Compare
Add getStat to OC\Archive\Zip Required to be able to read the mtime and other metadata. To give direct access to mtime Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
PVince81
force-pushed
the
enh/noid/zip-expose-stat
branch
from
62b6297 to
f5004e8
Compare
PVince81
added
3. to review
Pytal
approved these changes
Apr 11, 2022
Member
|
For some reason psalm doesnt find ZipArchive 🤔 |
Contributor
The php used is not built with zip extension. I had the problem before but I think I did not solve it (I added to the baseline or something). |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
|
See:
TL;DR: it’s not possible / too complicated to have ext-zip installed on the docker for the github psalm action, easier to add a stub for ZipArchive. |
Contributor
|
drone failure unrelated |
come-nc
approved these changes
Apr 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to be able to read the mtime and other metadata.
Note: not added on the interface because it would require adjusting TarStreamer as well