Merged
Conversation
Member
Author
|
one thing that is missing is that the folder mtime resets itself after writing into the folders, so we'd need to detect whenever we're done writing to a folder and then I'm not 100% sure about the current sequential approach. |
come-nc
reviewed
Apr 11, 2022
Collaborator
|
Looks good I think. |
come-nc
approved these changes
Apr 11, 2022
PVince81
force-pushed
the
enh/83/preserve-mtime
branch
2 times, most recently
from
2c123e1 to
8529af5
Compare
come-nc
approved these changes
Apr 11, 2022
Pytal
approved these changes
Apr 11, 2022
Closed
come-nc
force-pushed
the
enh/83/preserve-mtime
branch
from
8529af5 to
0994f64
Compare
Collaborator
|
(rebased on main) |
PVince81
added
4. to release
Now storing mtime as mtime metadata in the Zip file. The import procedure has been adjusted to use the "stat" information from the ZIP file which is accessible in sequential form, so the recursion was removed. This assumed that the ZIP entries are always correctly ordered. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
enh/83/preserve-mtime
branch
from
0994f64 to
e65d249
Compare
Member
Author
|
rebased again, hopefully now with updated API stubs |
Member
Author
|
hmm, I only added getStat on ZIP but it says the method doesn't exist on |
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Adds an exception for getStat from OC\Archive\Zip which is in a private namespace Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Member
Author
|
the "OC" private package is not in the included library with the stubs, so I've now updated the psalm baseline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now storing mtime as mtime metadata in the Zip file.
The import procedure has been adjusted to use the "stat" information
from the ZIP file which is accessible in sequential form, so the
recursion was removed. This assumed that the ZIP entries are always
correctly ordered.
For #83