fix: Fix getting trusted server other than the first#54371
Merged
Conversation
"array_filter" preserves the keys, so after the trusted servers were filtered "$server[0]" existed only if the server to get was the first one in the original array. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
2. developing
Member
Author
|
/backport to stable31 |
danxuliu
added
3. to review
danxuliu
requested review from
ArtificialOwl,
CarlSchwan and
leftybournes
and removed request for
a team
kesselb
approved these changes
Aug 12, 2025
st3iny
approved these changes
Aug 12, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Ahh, I love arcane PHP behavior ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #49973 (specifically, in 669e6ca)
array_filterpreserves the keys, so after the trusted servers were filtered$server[0]existed only if the server to get was the first one in the original array.How to test
Result with this pull request
No errors are logged
Result without this pull request
An error with message
Undefined array key 0 at...is logged