[stable31] fix: Fix getting trusted server other than the first#54381
Merged
[stable31] fix: Fix getting trusted server other than the first#54381
Conversation
backportbot
bot
added
bug
3. to review
kesselb
approved these changes
Aug 12, 2025
st3iny
approved these changes
Aug 13, 2025
Member
|
@danxuliu Test failure looks legit: |
AndyScherzinger
force-pushed
the
backport/54371/stable31
branch
from
4700e3f to
dfe75e2
Compare
"array_filter" preserves the keys, so after the trusted servers were filtered "$server[0]" existed only if the server to get was the first one in the original array. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/54371/stable31
branch
from
dfe75e2 to
9b691c2
Compare
Member
It was indeed. It was caused by a different syntax for PHPUnit data providers between stable31 and master. Fixed now. Thanks for the ping and sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #54371