Skip to content

perf: Allow filtering the directory content by mimetype #57891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 2 commits into from
Feb 12, 2026
Merged

perf: Allow filtering the directory content by mimetype #57891

CarlSchwan merged 2 commits into from
Feb 12, 2026
+146 −139

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jan 28, 2026 •
edited
Loading

Summary

Likely too late for 33

Optimize a bit the /ocs/v2.php/apps/files/api/v1/folder-tree as it means we have less entry to fetch which takes around 30s to execute on prod

image

TODO

  • ...

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Jan 28, 2026
@CarlSchwan CarlSchwan self-assigned this Jan 28, 2026
@CarlSchwan CarlSchwan requested a review from a team as a code owner January 28, 2026 22:56
@CarlSchwan CarlSchwan requested review from ArtificialOwl, come-nc, leftybournes and sorbaugh and removed request for a team January 28, 2026 22:56
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch 2 times, most recently from 2179cf1 to 5fe15da Compare January 29, 2026 10:04
@CarlSchwan CarlSchwan mentioned this pull request Jan 29, 2026
Merged
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from 5fe15da to c3eba5b Compare January 29, 2026 10:13
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch 2 times, most recently from b554ad8 to ec2a77e Compare January 29, 2026 10:45
provokateurin
provokateurin reviewed Jan 29, 2026
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from ec2a77e to e963419 Compare January 29, 2026 11:22
provokateurin
provokateurin reviewed Jan 29, 2026
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from e963419 to b8a657b Compare January 29, 2026 11:58
provokateurin
provokateurin requested changes Jan 29, 2026
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from b8a657b to e01e2ec Compare January 29, 2026 13:10
provokateurin
provokateurin reviewed Jan 29, 2026
View reviewed changes
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from e01e2ec to 084ef83 Compare January 29, 2026 13:44
provokateurin
provokateurin requested changes Jan 29, 2026
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I found some more 🙈

@CarlSchwan CarlSchwan mentioned this pull request Jan 29, 2026
Open
4 tasks
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from ab02e3f to ce34d55 Compare January 29, 2026 15:43
provokateurin
provokateurin approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it took so many rounds 😅

@CarlSchwan
Copy link
Member Author

CarlSchwan commented Jan 29, 2026

Sorry that it took so many rounds 😅

Thanks for the quality review :)

@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from ce34d55 to 41d052e Compare February 4, 2026 11:54
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from 41d052e to 3d5316b Compare February 5, 2026 10:42
@CarlSchwan CarlSchwan mentioned this pull request Feb 11, 2026
Merged
6 tasks
@CarlSchwan CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from 3d5316b to edd37d3 Compare February 11, 2026 23:36
@CarlSchwan CarlSchwan merged commit d35773b into master Feb 12, 2026
193 checks passed
@CarlSchwan CarlSchwan deleted the carl/getDirectoryContent-mimetypefilter branch February 12, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@cristianscheid cristianscheid cristianscheid approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews performance 🚀

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @provokateurin @cristianscheid