remove FileReader by KhafraDev · Pull Request #2728 · nodejs/undici

KhafraDev · 2024-02-09T17:35:59Z

No description provided.

KhafraDev · 2024-02-09T17:53:48Z

When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore!

mcollina · 2024-02-10T14:03:55Z

Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year.

KhafraDev · 2024-02-10T14:46:37Z

Of course not 😅. I was just talking about way in the future. We still have our own File.

ronag · 2024-02-25T09:46:00Z

Rebase to next branch?

codecov-commenter · 2024-02-25T15:11:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@8a940ec). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2728   +/-   ##
=======================================
  Coverage        ?   88.44%           
=======================================
  Files           ?       81           
  Lines           ?     7384           
  Branches        ?        0           
=======================================
  Hits            ?     6531           
  Misses          ?      853           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KhafraDev · 2024-03-01T22:13:06Z

can we land this? 👀

KhafraDev · 2024-03-01T22:35:50Z

I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. web-platform-tests/wpt#44893

Uzlopak

LGTM

* fetch: improve output for FormData * fetch: improve output for Response * fetch: improve output for Request * fetch: improve output for Request * feat: repair code * feat: repair code * feat: repair code * fix: repair codes & tests * fix: repair tests & response & request class * Update response.js Co-authored-by: Khafra <[email protected]> * fix: test repair --------- Co-authored-by: Mert Can Altin <[email protected]> Co-authored-by: Khafra <[email protected]>

Signed-off-by: Matteo Collina <[email protected]>

* test: improve performance of issue-803 test * increase timeout

* for some reason this fixes the test * cleanup custom format * fixup

* chore(.github/workflows): factor out test running * chore: add nightly tests Closes nodejs#2932

…2974) Bumps node from `4999fa1` to `577f8eb`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add types for composed dispatchers * Update types/dispatcher.d.ts * refactor: adjust --------- Co-authored-by: Matteo Collina <[email protected]>

* fix: count for error response and network errors * test: add specific test for fix * fix: conflict * refactor: address feedback

Signed-off-by: Matteo Collina <[email protected]>

) * fix(fetch): properly redirect non-ascii location header url * chore: fix typo * test: use simpler code * chore: clarify what the code does * chore: add comment * chore: normalize location url only if it contains invalid character * chore: apply suggestion See: nodejs#2971 (comment) * chore: remove redundant condition check

* Remove double-stringify in setCookie * Remove unnecessary semicolon

…se (nodejs#2983)

* make eventsource properties enumberable * Use kEnumerableProperty for eventsource immutable fields * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Aras Abbasi <[email protected]>

✅ Closes: nodejs#2988

* Refactored passing object to function params * Refactor write function argument order * Updated argument order in writeBuffer function

Bumps [borp](https://github.com/mcollina/borp) from 0.14.0 to 0.15.0. - [Release notes](https://github.com/mcollina/borp/releases) - [Commits](https://github.com/mcollina/borp/commits/v0.15.0) --- updated-dependencies: - dependency-name: borp dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [c8](https://github.com/bcoe/c8) from 9.1.0 to 10.0.0. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](bcoe/c8@v9.1.0...v10.0.0) --- updated-dependencies: - dependency-name: c8 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add missing error classes to types * test new types * test error includes data with count when etag mismatch * test content-range mismatch error * remove test debugging

* export interceptor to type def file Fixes: nodejs#3308 * fixup! add a test * fixup! add retry, redirect, dump and remove createRedirectInterceptor --------- Co-authored-by: jake li <[email protected]>

…3326) Bumps node from `e6d4495` to `075a5cc`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

)

Co-authored-by: Ezekiel Keator <[email protected]>

Signed-off-by: Matteo Collina <[email protected]>

Co-authored-by: github-actions <[email protected]>

* fix nodejs#3337 * fixup

* fix: types interceptors default export * test for bugs in typescript

Co-authored-by: github-actions <[email protected]>

Signed-off-by: Matteo Collina <[email protected]>

…3355) Bumps node from `075a5cc` to `9af472b`. --- updated-dependencies: - dependency-name: node dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* websocket: don't use pooled buffer in mask pool * add test * fixup * fixup

…s#3361)

…ple (nodejs#3363)

KhafraDev added the semver-major Features or fixes that will be included in the next semver major release label Feb 9, 2024

KhafraDev force-pushed the remove-filereader branch from 28d81d2 to fefe90d Compare February 25, 2024 15:06

Uzlopak approved these changes Mar 1, 2024

View reviewed changes

metcoder95 approved these changes Mar 3, 2024

View reviewed changes

mertcanaltin and others added 19 commits March 14, 2024 11:54

perf: optimize collectASequenceOfBytes (nodejs#2958)

4d59bf2

Bumped v6.9.0

3e59a2d

Signed-off-by: Matteo Collina <[email protected]>

test: fix flakyness of issue-803 test (nodejs#2960)

07019d0

* test: improve performance of issue-803 test * increase timeout

Cleanup format (nodejs#2959)

dcab693

* for some reason this fixes the test * cleanup custom format * fixup

Chore: run tests daily against node nightly (nodejs#2969)

3be7ec9

* chore(.github/workflows): factor out test running * chore: add nightly tests Closes nodejs#2932

fix: fix retry handler option (nodejs#2962)

9a56796

feat(TS): add types for composed dispatchers (nodejs#2967)

a045e56

* feat: add types for composed dispatchers * Update types/dispatcher.d.ts * refactor: adjust --------- Co-authored-by: Matteo Collina <[email protected]>

fix: count for error response and network errors (nodejs#2966)

d4332fc

* fix: count for error response and network errors * test: add specific test for fix * fix: conflict * refactor: address feedback

Bumped v6.10.0

e434060

Signed-off-by: Matteo Collina <[email protected]>

include strip-comments.js file for Node.js core

040cfcf

Signed-off-by: Matteo Collina <[email protected]>

Bumepd v6.10.1

dd3918f

Signed-off-by: Matteo Collina <[email protected]>

Do not fail test if streams support typed arrays (nodejs#2978)

2252a5f

Signed-off-by: Matteo Collina <[email protected]>

perf: Remove double-stringify in setCookie (nodejs#2980)

fcbf6de

* Remove double-stringify in setCookie * Remove unnecessary semicolon

[fix nodejs#2982] use DispatcherInterceptor type for Dispatcher#Compo…

8fce214

…se (nodejs#2983)

docs: ✏️ fixed benchmark links (nodejs#2991)

83f36b7

✅ Closes: nodejs#2988

DarkGL and others added 25 commits June 6, 2024 12:11

perf: convert object to params (nodejs#3302)

250c863

* Refactored passing object to function params * Refactor write function argument order * Updated argument order in writeBuffer function

fix: add missing error classes to types (nodejs#3316)

f9997bb

* add missing error classes to types * test new types * test error includes data with count when etag mismatch * test content-range mismatch error * remove test debugging

export interceptor to type def file (nodejs#3318)

1e508d7

* export interceptor to type def file Fixes: nodejs#3308 * fixup! add a test * fixup! add retry, redirect, dump and remove createRedirectInterceptor --------- Co-authored-by: jake li <[email protected]>

doc: clearify the behaviour of bodyTimeout in the request (nodejs#3324

7f54a24

)

feature: support pre-shared sessions (nodejs#3325)

39869b2

Co-authored-by: Ezekiel Keator <[email protected]>

Bumped v6.19.0

981fb3d

Signed-off-by: Matteo Collina <[email protected]>

don't append empty origin (nodejs#3335)

1573f69

Bumped v6.19.1 (nodejs#3336)

f6b9b44

Co-authored-by: github-actions <[email protected]>

fix nodejs#3337 (nodejs#3338)

035524e

* fix nodejs#3337 * fixup

build: use husky as husky install is deprecated (nodejs#3340)

5dadb95

fix: interceptors.d.ts has no default export (nodejs#3332)

a7441d8

* fix: types interceptors default export * test for bugs in typescript

Bumped v6.19.2 (nodejs#3342)

532b7b2

Co-authored-by: github-actions <[email protected]>

fetch: fix content-encoding order (nodejs#3343)

e5c242d

Add regression test for broken body (nodejs#3346)

9134ee6

Signed-off-by: Matteo Collina <[email protected]>

fix: post request signal (nodejs#3354)

a5eac88

Revert "fix: post request signal (nodejs#3354)" (nodejs#3359)

02c3a67

websocket: don't use pooled buffer in mask pool (nodejs#3357)

27b2589

* websocket: don't use pooled buffer in mask pool * add test * fixup * fixup

fix: consider bytes read when dumping (nodejs#3360)

0455e06

refactor: simplify signal handling (nodejs#3362)

3f4ef9a

fix: use explicit flag for when use has interacted with stream (nodej…

59fc6d5

…s#3361)

Refactor example documentation structure and add CacheableLookup exam…

dd98299

…ple (nodejs#3363)

KhafraDev mentioned this pull request Jun 24, 2024

undici - next #2835

Closed

13 tasks

KhafraDev force-pushed the remove-filereader branch 2 times, most recently from 3723521 to dd98299 Compare June 24, 2024 19:15

KhafraDev closed this Jun 24, 2024

KhafraDev deleted the remove-filereader branch September 3, 2024 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove FileReader#2728

remove FileReader#2728
KhafraDev wants to merge 375 commits intonodejs:nextfrom
KhafraDev:remove-filereader

KhafraDev commented Feb 9, 2024

Uh oh!

KhafraDev commented Feb 9, 2024

Uh oh!

mcollina commented Feb 10, 2024

Uh oh!

KhafraDev commented Feb 10, 2024

Uh oh!

ronag commented Feb 25, 2024

Uh oh!

codecov-commenter commented Feb 25, 2024 •

edited

Loading

Uh oh!

KhafraDev commented Mar 1, 2024

Uh oh!

KhafraDev commented Mar 1, 2024

Uh oh!

Uzlopak left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

KhafraDev commented Feb 9, 2024

Uh oh!

KhafraDev commented Feb 9, 2024

Uh oh!

mcollina commented Feb 10, 2024

Uh oh!

KhafraDev commented Feb 10, 2024

Uh oh!

ronag commented Feb 25, 2024

Uh oh!

codecov-commenter commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KhafraDev commented Mar 1, 2024

Uh oh!

KhafraDev commented Mar 1, 2024

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

codecov-commenter commented Feb 25, 2024 •

edited

Loading