fix(arborist): only replace hostname for resolved URL#8185
Merged
owlstronaut merged 3 commits intonpm:latestfrom Mar 26, 2025
Merged
fix(arborist): only replace hostname for resolved URL#8185owlstronaut merged 3 commits intonpm:latestfrom
owlstronaut merged 3 commits intonpm:latestfrom
Conversation
owlstronaut
approved these changes
Mar 26, 2025
Contributor
|
This is great, thanks for your contribution! |
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jun 10, 2025
…ls (#8356) When custom hosted git url are used to install dependencies it's not installing that dependency when the url is of `git+ssh://git@customgit.com:a/b/c.git` format instead of `git+ssh://git@customgit.com/a/b/c.git`. #### Cause: ` new URL(resolved)` throws an error which is getting caught and in-turn results in removal of that node. This behaviour was working as expected before this #8185 which replaced `hgi.parseUrl(resoved)` call to `new URL(resolved)` #### Fix: keep the `hgi.parseUrl` call to correctly parse the git url as mentioned/explained in this PR #5758 Fixes: #8331
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6110
There is an edge case where if an npm project is using a registry with a path the
replace-registry-hostis including the path from the registry url.Current Behavior:
Inputs:
registry=https://internal.mycompany.com/artifactory/api/npm/npm-allreplace-registry-host=alwaysOutput: "https://internal.mycompany.com/artifactory/api/npm/npm-all/api/npm/npm-all"
Expected Behavior:
Inputs:
registry=https://internal.mycompany.com/artifactory/api/npm/npm-allreplace-registry-host=alwaysOutput: "https://internal.mycompany.com/artifactory/api/npm/npm-all"
This fix resolves this inconsistency by refactoring the logic to construct URL objects from the registry and resolved strings and maps the hostname of the new registry to the hostname of the resolved url instead of doing string parsing.
I'm welcome to any feedback on this solution!