fix(arborist): use hosted-git-info to correctly parse resolved git urls#8356
Merged
wraithgar merged 2 commits intonpm:latestfrom Jun 10, 2025
Merged
fix(arborist): use hosted-git-info to correctly parse resolved git urls#8356wraithgar merged 2 commits intonpm:latestfrom
wraithgar merged 2 commits intonpm:latestfrom
Conversation
milaninfy
force-pushed
the
mm/fix-resolved-git-url
branch
from
a45ba27 to
0766793
Compare
milaninfy
changed the title
wraithgar
approved these changes
Jun 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When custom hosted git url are used to install dependencies it's not installing that dependency when the url is of
git+ssh://git@customgit.com:a/b/c.gitformat instead ofgit+ssh://git@customgit.com/a/b/c.git.Cause:
new URL(resolved)throws an error which is getting caught and in-turn results in removal of that node.This behaviour was working as expected before this #8185 which replaced
hgi.parseUrl(resoved)call tonew URL(resolved)Fix:
keep the
hgi.parseUrlcall to correctly parse the git url as mentioned/explained in this PR #5758Fixes: #8331