Draft
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
force-pushed
the
martin/trivial/disable-metrics-collection
branch
from
8c852e7 to
5380a5e
Compare
martintomazic
commented
Mar 25, 2026
Comment on lines
+136
to
+138
| # # Wait for all jobs defined before this point | ||
| # # to finish running in parallel before continuing. | ||
| # - wait |
Contributor
Author
There was a problem hiding this comment.
We might as well clean the some other env variables etc if we are serious about deprecating this. Commenting for the start is definitely improvement.
Contributor
Author
There was a problem hiding this comment.
Are daily benchmarks still needed as a daily sanity? Maybe rename the pipeline if this is basically daily sanity (e.g. if no PRs happen).
martintomazic
commented
Mar 25, 2026
This matches the parallelization and timeout of the code.pipeline.yml that also runs all default scenarios.
Contributor
Author
|
Long test seems to work: Daily benchmarks seems to be stuck at reading non-existing stuff, likely a config/pipeline issue (exploring): |
martintomazic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6486.
Daily benchmarks and and long test pipelines have been failing for a while: https://buildkite.com/oasisprotocol
as the push gateway (
https://pushgateway-buildkite.ops.oasiscloud.io) doesn't exist anymore.They weren't used for 1 year+, neither are metrics and their regression from light e2e tests representative therefore we can safely disable them if not remove.
Lets open a new issue instead for creating a new pipeline that triggers on the new oasis-core release and starts a representative load (e.g. sync from latest checkpoint or few months back in time) and check performance regression + store relevant artifacts long time.