Skip to content

CI: Fix daily benchmarks pipeline #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martintomazic wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

CI: Fix daily benchmarks pipeline #6482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5380a5e
CI: Disable pushing metrics during e2e tests
martintomazic Mar 25, 2026
0a5f1f6
.buildkite/benchmarks.pipeline: Increase parallelization
martintomazic Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions .buildkite/benchmarks.pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,13 @@ steps:
# E2E test jobs with enabled benchmarking
#########################################
- label: E2E tests
parallelism: 7
timeout_in_minutes: 30
parallelism: 30
timeout_in_minutes: 20
command:
- .buildkite/scripts/download_e2e_test_artifacts.sh
- rm -rf /var/tmp/benchmarks/*
- >-
.buildkite/scripts/test_e2e.sh
--metrics.address $METRICS_PUSH_ADDR
--metrics.interval 5s
--metrics.labels instance=$BUILDKITE_PIPELINE_NAME-$BUILDKITE_BUILD_NUMBER
--num_runs $NUM_RUNS
--scenario $SCENARIOS
env:
Expand All @@ -136,16 +133,16 @@ steps:
plugins:
<<: *docker_plugin

# Wait for all jobs defined before this point
# to finish running in parallel before continuing.
- wait
# # Wait for all jobs defined before this point
# # to finish running in parallel before continuing.
# - wait
Comment on lines +136 to +138
Copy link
Copy Markdown
Contributor Author

@martintomazic martintomazic Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well clean the some other env variables etc if we are serious about deprecating this. Commenting for the start is definitely improvement.

Copy link
Copy Markdown
Contributor Author

@martintomazic martintomazic Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are daily benchmarks still needed as a daily sanity? Maybe rename the pipeline if this is basically daily sanity (e.g. if no PRs happen).


###########################
# Compare benchmark results
###########################
- label: Benchmark analysis
command:
- .buildkite/scripts/download_e2e_test_artifacts.sh
- .buildkite/scripts/daily_benchmark_analysis.sh
plugins:
<<: *docker_plugin
# ###########################
# # Compare benchmark results
# ###########################
# - label: Benchmark analysis
# command:
# - .buildkite/scripts/download_e2e_test_artifacts.sh
# - .buildkite/scripts/daily_benchmark_analysis.sh
# plugins:
# <<: *docker_plugin
3 changes: 0 additions & 3 deletions .buildkite/scripts/daily_benchmark_analysis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
set -ux

./go/oasis-test-runner/oasis-test-runner cmp \
--metrics.address $METRICS_QUERY_ADDR \
--metrics.source.git_branch $METRICS_SOURCE_GIT_BRANCH \
--metrics.target.git_branch $METRICS_TARGET_GIT_BRANCH \
--scenario $SCENARIOS \
--log.level INFO \
--log.format JSON \
Expand Down
2 changes: 0 additions & 2 deletions .buildkite/scripts/daily_txsource.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ set -euxo pipefail

if [[ $BUILDKITE_RETRY_COUNT == 0 ]]; then
./.buildkite/scripts/test_e2e.sh \
--metrics.address $METRICS_PUSH_ADDR \
--metrics.labels instance=$BUILDKITE_PIPELINE_NAME-$BUILDKITE_BUILD_NUMBER \
--scenario_timeout 900m \
--scenario e2e/runtime/txsource-multi \
"$@"
Expand Down
Empty file added .changelog/6482.trivial.md
View file
Open in desktop
Empty file.
Loading