Repository navigation
fix(sdd): run review-package from project worktree - #2603
Open
tianxingjian2406 wants to merge 1 commit into
Open
tianxingjian2406 wants to merge 1 commit into
tianxingjian2406 wants to merge 1 commit into
Conversation
Signed-off-by: tianxingjian2406 <2550975@tongji.edu.cn>
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
What problem are you trying to solve?
Issue #2525 reports a path error in the
subagent-driven-developmentskill.The skill tells the controller to run
review-packagefrom the skill directory.An installed plugin can place that directory inside a plugin cache.
Git then reads the plugin cache instead of the project worktree.
The command can reject valid commit IDs and plan paths.
What does this PR change?
The skill now tells the controller to run the helper with an absolute skill path.
The skill now names the project worktree as the working directory.
The change updates both current
review-packagecall sites.Fixes #2525.
Is this change appropriate for the core library?
Yes. The skill ships with Superpowers and serves every project workflow.
The change adds no dependency and no project-specific behavior.
What alternatives did you consider?
Does this PR contain multiple unrelated changes?
No. Both edits fix the same caller-working-directory error.
Existing PRs
PLAN_FILE. fix(sdd): add -C DIR flag to review-package for harness allowlisting #1809 adds an optional-Cflag to an older script interface. fix(sdd): include commit bodies in review packages #2303 preserves commit bodies. These PRs do not fix the two skill instructions changed here.Environment tested
New harness support (required if this PR adds a new harness)
Not applicable. This PR changes an existing skill instruction.
Evaluation
Rigor
superpowers:writing-skillsguidance and completed two adversarial pressure scenarios. The issue report supplies the baseline failure.Human review