Skip to content

fix(sdd): run review-package from project worktree - #2603

Open
tianxingjian2406 wants to merge 1 commit into
obra:devfrom
tianxingjian2406:fix/issue-2525
Open

tianxingjian2406 wants to merge 1 commit into
obra:devfrom
tianxingjian2406:fix/issue-2525

Conversation

@tianxingjian2406

Copy link
Copy Markdown

This PR targets dev.

Who is submitting this PR? (required)

Field Value
Your model + version GPT-5, Codex runtime
Harness + version Codex desktop, version unavailable in this session
All plugins installed caveman; context-mode; created-by-me-remote; headroom-marketplace; omc; openai-bundled; openai-curated-remote; openai-primary-runtime; ponytail; say
Human partner who reviewed this diff 暮雪先生

What problem are you trying to solve?

Issue #2525 reports a path error in the subagent-driven-development skill.

The skill tells the controller to run review-package from the skill directory.

An installed plugin can place that directory inside a plugin cache.

Git then reads the plugin cache instead of the project worktree.

The command can reject valid commit IDs and plan paths.

What does this PR change?

The skill now tells the controller to run the helper with an absolute skill path.

The skill now names the project worktree as the working directory.

The change updates both current review-package call sites.

Fixes #2525.

Is this change appropriate for the core library?

Yes. The skill ships with Superpowers and serves every project workflow.

The change adds no dependency and no project-specific behavior.

What alternatives did you consider?

  • Keep the relative path and add a warning. This keeps the failure path.
  • Change the helper script. The issue affects the caller path, so the script already has the required behavior.
  • Add a new wrapper. The existing script path solves the problem with fewer files.

Does this PR contain multiple unrelated changes?

No. Both edits fix the same caller-working-directory error.

Existing PRs

Environment tested

Harness (e.g. Claude Code, Cursor) Harness version Model Model version/ID
Codex desktop on Windows unavailable in this session GPT-5 Codex runtime

New harness support (required if this PR adds a new harness)

Not applicable. This PR changes an existing skill instruction.

Evaluation

Rigor

  • If this is a skills change: I used superpowers:writing-skills guidance and completed two adversarial pressure scenarios. The issue report supplies the baseline failure.
  • This change was tested against the reported path failure and two pressure scenarios.
  • I did not modify the Red Flags table, rationalization lists, or human-partner language.

Human review

  • A human reviewed the complete proposed diff before submission.

Signed-off-by: tianxingjian2406 <2550975@tongji.edu.cn>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 00:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants