Release/2.2.3#692
Conversation
Adjusted github issue templates
Fix/run cluster for main hotfix
|
@milesAraya
|
…nflicts. Kept all current changes
|
@itutu-tienday There were some merge conflicts when trying to merge release/2.2.2 into optinist/main
It seems this method of merging opinist/develop-main into the release branch seems like a good idea for these hotfix cases |
Remove code related to post_process as this is a cloud function Remove code related to post_process as this is a cloud function
milesAraya
force-pushed
the
release/2.2.2
branch
from
021f110 to
1f91389
Compare
…d avoid missing nwb components
|
|
||
| @classmethod | ||
| def __deep_merge(cls, dict1, dict2): | ||
| def __change_dict_key_exist(cls, input_info, rule_config: Rule): |
There was a problem hiding this comment.
This method name appears to have already been changed in barebone develop-main (__change_dict_key_exist -> __align_input_info_content_keys).
The v2.2.2 release is OK, but please fix and test it when backporting to devleop-main after the release to avoid breaking existing methods in develop-main.
There was a problem hiding this comment.
If the method does not exist in oist/optinist, you may want to use the latest method name (__align_input_info_content_keys) from the beginning. (There is no problem with leaving it as it is, so we will leave it up to you.)
| @@ -1 +1 @@ | |||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="manifest" href="/static/manifest.json"/><title>OptiNiSt</title><script defer="defer" src="/static/js/main.4bda1ce5.js"></script><link href="/static/css/main.95e38137.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> | |||
| <!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="manifest" href="/static/manifest.json"/><title>OptiNiSt</title><script defer="defer" src="/static/js/main.426cd4d4.js"></script><link href="/static/css/main.95e38137.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html> No newline at end of file | |||
There was a problem hiding this comment.
The frontend build materials have already been removed from barebone develop-main in response to the following PR:
Please be careful not to include these build materials when backporting to barebone.
*Alternatively, it may be better to exclude the frontend build from this hot fix release (though there is a restriction that the version number will not be updated).
There was a problem hiding this comment.
I think i just followed the release procedure. Does the release procedure need to be updated to explain how to remove the frontend build?
There was a problem hiding this comment.
This is a special release because it's a hotfix release.
Personally, I think it's fine to leave the frontend materials out of the scope of this update. (As long as you record your intentions in the work log, it should be fine.)
If there's a possibility that the hotfix release will continue, it might be a good idea to release the frontend build materials and PR first at some point. (Once v2.4.0 is released, this issue won't recur.)
2 participants
Content
Added fix to solve error in using run_cluster.py to run snakemake.yaml files, in particular with new nwb_template format
Related PR: arayabrain#895