Skip to content

[Access] Don't require stateStreamBackend in access bootstrap#8462

Merged
peterargue merged 1 commit intomasterfrom
peter/fix-access-bootstrap-statestream
Feb 24, 2026
Merged

[Access] Don't require stateStreamBackend in access bootstrap#8462
peterargue merged 1 commit intomasterfrom
peter/fix-access-bootstrap-statestream

Conversation

@peterargue
Copy link
Copy Markdown
Contributor

@peterargue peterargue commented Feb 24, 2026

This is causing ANs with the state stream API disabled to crash.

Summary by CodeRabbit

  • Refactor
    • Improved internal initialization flexibility for the state stream backend component by allowing conditional nil handling in downstream logic.

@peterargue peterargue requested a review from a team as a code owner February 24, 2026 19:26
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4164ecb and 435a609.

📒 Files selected for processing (1)
  • cmd/access/node_builder/access_node_builder.go

📝 Walkthrough

Walkthrough

A single-line change in the access node builder removes a non-nil assertion from the stateStreamBackend parameter passed to the RPC engine builder, allowing the value to be nil and delegating nil-handling responsibility to downstream code.

Changes

Cohort / File(s) Summary
State Stream Backend Initialization
cmd/access/node_builder/access_node_builder.go
Removed utils.NotNil() wrapper from stateStreamBackend argument in RPC engine builder call, permitting nil values to flow downstream for handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through nil's great way,
Assertions fade like morning's gray,
Let downstream logic have its say—
Trust the flow, come what may! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the requirement for a non-nil stateStreamBackend in the access node bootstrap process by replacing a NotNil assertion with a direct value.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch peter/fix-access-bootstrap-statestream

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterargue peterargue added this pull request to the merge queue Feb 24, 2026
Merged via the queue into master with commit fc1a963 Feb 24, 2026
61 checks passed
@peterargue peterargue deleted the peter/fix-access-bootstrap-statestream branch February 24, 2026 20:03
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants