Skip to content

[Access] Don't require stateStreamBackend in access bootstrap#8463

Merged
peterargue merged 1 commit intov0.47from
peter/fix-access-bootstrap-statestream-v0.47
Feb 24, 2026
Merged

[Access] Don't require stateStreamBackend in access bootstrap#8463
peterargue merged 1 commit intov0.47from
peter/fix-access-bootstrap-statestream-v0.47

Conversation

@peterargue
Copy link
Contributor

@peterargue peterargue commented Feb 24, 2026

Backports: #8462

Summary by CodeRabbit

  • Refactor
    • Updated access node initialization to make the state stream backend optional, improving flexibility during node startup configuration.

@peterargue peterargue requested a review from a team as a code owner February 24, 2026 19:28
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The RPC engine builder call now passes the state stream backend directly instead of asserting its non-nil status. This removes a validation check, allowing the state stream backend to be nil during initialization rather than requiring it to be present.

Changes

Cohort / File(s) Summary
State Stream Backend Parameter
cmd/access/node_builder/access_node_builder.go
Removed utils.NotNil() assertion when passing builder.stateStreamBackend to RPC engine builder, making the parameter optional rather than required.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through code so neat,
Removing guards that once stood tall—
The state stream now can flutter free,
No assertion holds its call,
Flexibility blooms for all! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: removing the requirement for stateStreamBackend during access node bootstrap, which matches the core modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch peter/fix-access-bootstrap-statestream-v0.47

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterargue peterargue changed the base branch from master to v0.47 February 24, 2026 19:29
/// Nonce of the address
access(all)
fun nonce(): UInt64 {
view fun nonce(): UInt64 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there are these unrelated changes? did you merge latest v0.47 to your branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what happened, but I fixed and force pushed

@peterargue peterargue force-pushed the peter/fix-access-bootstrap-statestream-v0.47 branch from d01ae45 to 305666c Compare February 24, 2026 19:32
@peterargue peterargue merged commit cf85bdb into v0.47 Feb 24, 2026
57 checks passed
@peterargue peterargue deleted the peter/fix-access-bootstrap-statestream-v0.47 branch February 24, 2026 19:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants