Repository navigation
remove "Triaging labels" section in readme & don't capture exitOnCtrlC - #16
Merged
Merged
Conversation
zeekay
referenced
this pull request
in hanzoai/dev
Sep 8, 2025
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 3, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this upgrade's triage: - Patch openai#2 reworked: upstream split sessions/records.rs into per-agent readers, so the compact-boundary fix moved to records_cla.rs. - Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the error mapping the Slack normalization hooks. - Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification. - Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the UnicodeWidthStr import; use crate::width::display_width instead. - Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock companion update. - 888f445 dropped as a stale lockfile restamp, with a note that the manifest's base line had drifted from the real merge base. Rows 16 and 17 squashed from 33 development commits into one commit each; row 18 left standalone so it stays visible as a drop candidate. utils/pty kept separate from the statusline feature so it can be upstreamed on its own.
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 3, 2026
Fold the durable findings from the 0.146.0 -> 0.147.0-alpha.4 upstream review into the manifest so the next upgrade does not rediscover them. Per-patch updates: - openai#6 invalid_grant: upstream split TokenRefreshFailed/TokenRefreshRejected, making this the strongest drop candidate in the stack. - openai#12: conflict watch is context_manager/history.rs; normalize.rs is clean. - openai#13 wait_agent: upstream raised the recommended timeout to minute-scale, so the fast-fail now saves a minute per poll rather than seconds. - openai#14 Slack: rmcp-client lost its reqwest exception in deny.toml, so the patch must stay on codex-http-client types or cargo deny fails. - openai#16: record the ratatui cell-semantics hazard and the standing rule that fork TUI code measures with crate::width::*, never unicode_width directly. - openai#17: upstream's Windows Interrupt change composes with the containment patch; note the hard tree-terminate caveat. New "Upstream watch list" section covering the release-artifact rename and recompression, out-of-process code mode, precomputed protocol schemas, the PlannedTools -> ToolRegistry collapse, isPinned removal, and the divergent-copy hazard that produced patch #7c. Also records the environment's known-failing ide_context tests (umask 002 against upstream-untouched code) and the just-vs-cargo stack requirement, plus a post-rebase verification checklist covering the failure classes that a green test run does not detect.
KitPan
added a commit
to KitPan/codex
that referenced
this pull request
Aug 4, 2026
…persistence (P1-5) Four hardening pieces on top of the P1-4 orchestrator (judge hooks already landed there): - circuit breaker (openai#6): consecutive same-signature tool failures trip at a threshold (default 5) and kill the task tree via the shared interrupt path; any success resets the streak. Signatures are deliberately coarse — shell-wrapper-stripped head token — because the observed 328-failure loop was one tool with varying arguments. Breaker-tripped tasks finalize as Failed (never Interrupted). - southbound auto-retry (openai#7): transient-failure relaunch of the same LaunchPlan, triple-gated — failure text matches known transient patterns (stream disconnected / connection refused / timeouts, from the Phase 0 window postmortems), zero tool activity observed (no side-effect risk), and a retry budget (2). Each attempt streams to its own events file (<id>.aN.jsonl); retries recorded on the task. - preflight (openai#7/openai#16): bare-IP endpoint probe before any resource allocation, with triage in the error — refused (host up, service down; hints at dspark_proxy), timeout (host likely down; suggest ping triage), or HTTP status anomaly. - diff persistence (openai#8): finalize now auto-commits the dirty worktree onto the task branch before reclaim (models edit files but never commit — previously KeepBranch preserved a ref pointing at base and the actual output evaporated with the worktree). diff --stat lands on the record and in status; full diff reviewable via the branch. Tests: 30 lib (signature/breaker/transient units, worktree commit-and-retrieve) + 10 e2e (breaker trip <10s, streak reset, retry-then-recover with per-attempt event files, non-transient no-retry with stderr surfaced, diff preserved through reclaim, preflight dead-vs-live endpoints). clippy clean. Authored by Claude Fable 5 (Claude Code).
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 11, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this upgrade's triage: - Patch openai#2 reworked: upstream split sessions/records.rs into per-agent readers, so the compact-boundary fix moved to records_cla.rs. - Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the error mapping the Slack normalization hooks. - Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification. - Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the UnicodeWidthStr import; use crate::width::display_width instead. - Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock companion update. - 888f445 dropped as a stale lockfile restamp, with a note that the manifest's base line had drifted from the real merge base. Rows 16 and 17 squashed from 33 development commits into one commit each; row 18 left standalone so it stays visible as a drop candidate. utils/pty kept separate from the statusline feature so it can be upstreamed on its own.
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 11, 2026
Fold the durable findings from the 0.146.0 -> 0.147.0-alpha.4 upstream review into the manifest so the next upgrade does not rediscover them. Per-patch updates: - openai#6 invalid_grant: upstream split TokenRefreshFailed/TokenRefreshRejected, making this the strongest drop candidate in the stack. - openai#12: conflict watch is context_manager/history.rs; normalize.rs is clean. - openai#13 wait_agent: upstream raised the recommended timeout to minute-scale, so the fast-fail now saves a minute per poll rather than seconds. - openai#14 Slack: rmcp-client lost its reqwest exception in deny.toml, so the patch must stay on codex-http-client types or cargo deny fails. - openai#16: record the ratatui cell-semantics hazard and the standing rule that fork TUI code measures with crate::width::*, never unicode_width directly. - openai#17: upstream's Windows Interrupt change composes with the containment patch; note the hard tree-terminate caveat. New "Upstream watch list" section covering the release-artifact rename and recompression, out-of-process code mode, precomputed protocol schemas, the PlannedTools -> ToolRegistry collapse, isPinned removal, and the divergent-copy hazard that produced patch #7c. Also records the environment's known-failing ide_context tests (umask 002 against upstream-untouched code) and the just-vs-cargo stack requirement, plus a post-rebase verification checklist covering the failure classes that a green test run does not detect.
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 11, 2026
Move the base to rust-v0.147.0-alpha.4 (8bf9d5d) and record this upgrade's triage: - Patch openai#2 reworked: upstream split sessions/records.rs into per-agent readers, so the compact-boundary fix moved to records_cla.rs. - Patch openai#14 reworked: upstream's configured-HTTP-client rewrite changed the error mapping the Slack normalization hooks. - Patch openai#15 reworked: upstream boxed AppServerEvent::ServerNotification. - Patch openai#16 reworked: upstream's terminal_hyperlinks refactor dropped the UnicodeWidthStr import; use crate::width::display_width instead. - Patch openai#11 retargeted; bazel-lock-check passes with no MODULE.bazel.lock companion update. - 888f445 dropped as a stale lockfile restamp, with a note that the manifest's base line had drifted from the real merge base. Rows 16 and 17 squashed from 33 development commits into one commit each; row 18 left standalone so it stays visible as a drop candidate. utils/pty kept separate from the statusline feature so it can be upstreamed on its own.
gabrielbryk
added a commit
to gabrielbryk/codex
that referenced
this pull request
Aug 11, 2026
Fold the durable findings from the 0.146.0 -> 0.147.0-alpha.4 upstream review into the manifest so the next upgrade does not rediscover them. Per-patch updates: - openai#6 invalid_grant: upstream split TokenRefreshFailed/TokenRefreshRejected, making this the strongest drop candidate in the stack. - openai#12: conflict watch is context_manager/history.rs; normalize.rs is clean. - openai#13 wait_agent: upstream raised the recommended timeout to minute-scale, so the fast-fail now saves a minute per poll rather than seconds. - openai#14 Slack: rmcp-client lost its reqwest exception in deny.toml, so the patch must stay on codex-http-client types or cargo deny fails. - openai#16: record the ratatui cell-semantics hazard and the standing rule that fork TUI code measures with crate::width::*, never unicode_width directly. - openai#17: upstream's Windows Interrupt change composes with the containment patch; note the hard tree-terminate caveat. New "Upstream watch list" section covering the release-artifact rename and recompression, out-of-process code mode, precomputed protocol schemas, the PlannedTools -> ToolRegistry collapse, isPinned removal, and the divergent-copy hazard that produced patch #7c. Also records the environment's known-failing ide_context tests (umask 002 against upstream-untouched code) and the just-vs-cargo stack requirement, plus a post-rebase verification checklist covering the failure classes that a green test run does not detect.
jiangshengdev
added a commit
to jiangshengdev/codex
that referenced
this pull request
Sep 16, 2026
Refs openai#16. Keep the toolbar outside the preview, remove DEV DOM without resetting scenarios, and reset the choice on reload. Add manager-to-preview E2E coverage.
friel-openai
referenced
this pull request
in friel-openai/codex
Sep 16, 2026
Track the latest published Codex prerelease at its exact tagged commit. Refresh the supervisor and active-goal editing patch context to retain Saffrodex tool registration alongside the upstream guardian changes.
soddygo
added a commit
to nuwax-ai/codex
that referenced
this pull request
Sep 24, 2026
Third batch of confirmed review findings: - openai#15 the genai bridge flattened every error into a Network string, so codex-core's 401-recovery loop (start errors only) never fired for it: map_genai_error now walks the error chain to webc::Error:: ResponseFailedStatus and preserves the HTTP status as Http{status}, matching the rig bridge contract. - openai#16 gateway OAuth secondary auth headers (cookies, api-key variants, gateway tokens) were dropped by both bridges — after completing gateway OAuth the actual requests could still 401: both bridges now merge the full auth header set minus the PRIMARY Authorization header (the adapter rebuilds that one; duplicating it trips reverse proxies). - openai#13 the Ask preset's description promised approval before every command, but OnRequest + an unrestricted profile auto-allows non-dangerous commands (verified in exec_policy): the copy now states the actual behavior instead. Permission semantics left unchanged — changing those needs product direction, not a review fix. Units 48/48 across both bridges; full live matrix 64/64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.