Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

concurrent reads on ReadTopologyInstanceBufferable#182

Merged
shlomi-noach merged 9 commits into
masterfrom
concurrent-discover-instance
Jun 4, 2017
Merged

concurrent reads on ReadTopologyInstanceBufferable#182
shlomi-noach merged 9 commits into
masterfrom
concurrent-discover-instance

Conversation

@shlomi-noach
Copy link
Copy Markdown
Collaborator

Some reads on ReadTopologyInstanceBufferable() are safe to run concurrently. Such are reads that subsequent actions do not rely upon.

Running such reads concurrently reduces instance read latency.

@shlomi-noach shlomi-noach temporarily deployed to production May 21, 2017 06:34 Inactive
@shlomi-noach shlomi-noach changed the title concurrent readson ReadTopologyInstanceBufferable concurrent reads on ReadTopologyInstanceBufferable May 21, 2017
@shlomi-noach shlomi-noach temporarily deployed to production May 21, 2017 07:07 Inactive
@shlomi-noach
Copy link
Copy Markdown
Collaborator Author

On some remote DC, high latency network, this reduced instance detection time from ~560ms to ~250ms. This is a substantial reduction.

For local DC or low latency networks I see little difference (and this is expected).

@shlomi-noach shlomi-noach temporarily deployed to production May 21, 2017 15:32 Inactive
@shlomi-noach shlomi-noach deployed to production/github-mysqlutil May 24, 2017 11:13 Active
@shlomi-noach
Copy link
Copy Markdown
Collaborator Author

1cb9736 further reduces to ~190ms

@shlomi-noach shlomi-noach deployed to production/github-mysqlutil May 28, 2017 05:35 Active
@shlomi-noach shlomi-noach deployed to production/github-mysqlutil May 29, 2017 09:07 Active
@shlomi-noach shlomi-noach had a problem deploying to production/github-mysqlutil May 29, 2017 09:07 Failure
@shlomi-noach
Copy link
Copy Markdown
Collaborator Author

This deploys well.

@shlomi-noach shlomi-noach merged commit abfb59f into master Jun 4, 2017
@shlomi-noach shlomi-noach deleted the concurrent-discover-instance branch June 4, 2017 05:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant