This repository was archived by the owner on Feb 18, 2025. It is now read-only.
fixing concurrency execution of ReplicationLagQuery#219
Merged
Conversation
Collaborator
|
Nice 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#182 split instance detection and probing queries to run concurrently. The
ReplicationLagQuerywas one of the queries to run concurrently and to be executed straight away.However that was a mistake, since
ReplicationLagQuerycompetes with another query,SHOW SLAVE STATUSfor the replication lag.SHOW SLAVE STATUSmust run first, andReplicationLagQuerymust run later, so that it can override, if needed, theReplicationLagSecondsvalue.There is no problem for
ReplicationLagQueryto run concurrently, as long as it gets executed afterSHOW SLAVE STATUS.cc @jonahberquist