[ci] use go mod instead of go get in spec.bats#4264
Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom Apr 30, 2024
Merged
[ci] use go mod instead of go get in spec.bats#4264AkihiroSuda merged 1 commit intoopencontainers:mainfrom
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
Conversation
Closed
kolyshkin
reviewed
Apr 30, 2024
tests/integration/spec.bats
Outdated
Comment on lines
+42
to
+43
| cd ../../ | ||
| ./runtime-spec/schema/validate "$SCHEMA" config.json |
Contributor
There was a problem hiding this comment.
Maybe easier to do
./validate config-schema.json ../../config.json(and remove cd and SCHEMA= above)
Long term, I guess, we need to fix runtime-spec to
- embed config-schema.json into validate binary
- add go.mod to runtime-spec
- make it easier to use so
go install github.com/opencontainers/runtime-spec/schema/validate@$SPEC_REFresults invalidatebinary ready to be used.
cba0420 to
488f33b
Compare
Signed-off-by: lifubang <lifubang@acmcoder.com>
488f33b to
75e0219
Compare
AkihiroSuda
approved these changes
Apr 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run integration test in go 1.22, it got an error:
Although we have not supported go 1.22 yet, but I think we should update the spec.bat first.