Conversation
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
00b81bf to
83326a3
Compare
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
83326a3 to
aa78741
Compare
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks for creating this PR so promptly!
It would also LGTM without listing the changes for ci, dependencies and tests. But I think like this is fine, no need to change it :)
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Left some notes.
Additionally, we need to release 1.1.13 first and then incorporate 1.1.13 release notes here, and make sure there are no overlaps.
|
draft until 1.1.13 is released |
Yes, I'll address all your requested changes and update the 1.1.13 release notes after v1.1.13 released. |
It's time! :) |
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
2 times, most recently
from
9a8086e to
363b3a1
Compare
|
@kolyshkin Ready to go! |
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
Did some nit comments. But this mostly LGTM
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
363b3a1 to
8e6c2b9
Compare
|
@lifubang can we fix the changelog to be sorted by version number, not by the release date? And change the release date, to, say, next Tuesday (25th of June). |
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
8e6c2b9 to
bf448c4
Compare
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
3 times, most recently
from
c1a5325 to
93ea985
Compare
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
Sorry I took some time, I was afk.
Added some nits, but this mostly LGTM.
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
93ea985 to
aff5fdf
Compare
Signed-off-by: lifubang <lifubang@acmcoder.com>
Signed-off-by: lifubang <lifubang@acmcoder.com>
lifubang
force-pushed
the
release-1.2.0-rc.2
branch
from
aff5fdf to
5ea7625
Compare
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Let's see if we can still make the release today, as the changelog says 🤞
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
|
||
| * cgroup v2: do not set swap to 0 or unlimited when it's not available. (#4188) | ||
| * Set the default value of CpuBurst to nil instead of 0. (#4210, #4211) | ||
| * runc exec: fix setting rlimit_nofile. (#4195, #4265, #4282, #4290) |
There was a problem hiding this comment.
This should not be here since it's also in v1.1.13 but it's too late to fix this. I will remove this line in the github release notes.
| * cgroup v2: do not set swap to 0 or unlimited when it's not available. (#4188) | ||
| * Set the default value of CpuBurst to nil instead of 0. (#4210, #4211) | ||
| * runc exec: fix setting rlimit_nofile. (#4195, #4265, #4282, #4290) | ||
| * libct/cg/fs: fix setting rt_period vs rt_runtime. (#4094, #4258) |
There was a problem hiding this comment.
Same here. Sorry I overlooked this.
| * Set the default value of CpuBurst to nil instead of 0. (#4210, #4211) | ||
| * runc exec: fix setting rlimit_nofile. (#4195, #4265, #4282, #4290) | ||
| * libct/cg/fs: fix setting rt_period vs rt_runtime. (#4094, #4258) | ||
| * script/*: fix gpg usage wrt keyboxd. (#4189) |
| * runc exec: fix setting rlimit_nofile. (#4195, #4265, #4282, #4290) | ||
| * libct/cg/fs: fix setting rt_period vs rt_runtime. (#4094, #4258) | ||
| * script/*: fix gpg usage wrt keyboxd. (#4189) | ||
| * Fix a debug log message for user namespaces in nsexec. (#4311) |
|
|
||
| ### Changed | ||
|
|
||
| * libcontainer: allow containers to make apps think fips is enabled/disabled for testing. (#4246) |
There was a problem hiding this comment.
same here, it's in 1.1.13.
6 participants
[1.2.0-rc.2] - 2024-06-26
Important Notes
import libcontainer/cgroups/devices. (Decouple setting cgroup device rules from cgroup manager #3452, libct: decouple libct/cg/devices #4248)
(see runc doesn't work with go1.22 #4233 for more details)
Added
Fixed
Changed