fix return 130 rpc, if player have a bad name#900
Closed
atomlin-git wants to merge 1 commit intoopenmultiplayer:masterfrom
atomlin-git:fix738issue
Closed
fix return 130 rpc, if player have a bad name#900atomlin-git wants to merge 1 commit intoopenmultiplayer:masterfrom atomlin-git:fix738issue
atomlin-git wants to merge 1 commit intoopenmultiplayer:masterfrom
atomlin-git:fix738issue
Conversation
…turn nullptr result below
Hual
previously approved these changes
Mar 29, 2024
Collaborator
|
While this change makes sense I don't see how it would actually fix the linked issue |
Contributor
Author
|
RPC simply does not have time to reach the player With out changes: With changes: |
Collaborator
But isn't the player being kicked right after that in another function? |
Contributor
Author
|
More better solution in #906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #738