Fixed: several connection logic issues#906
Merged
AmyrAhmady merged 4 commits intoopenmultiplayer:masterfrom Apr 4, 2024
Merged
Fixed: several connection logic issues#906AmyrAhmady merged 4 commits intoopenmultiplayer:masterfrom
AmyrAhmady merged 4 commits intoopenmultiplayer:masterfrom
Conversation
Contributor
uifdev
commented
Mar 31, 2024
uifdev
commented
- Clients weren't kicked if the client version doesn't match the server version.
- Clients were flagged as logged in to the game regardless of the result of OnPeerConnect, meaning they wouldn't be dropped in the event of a failure.
Hual
reviewed
Apr 1, 2024
Contributor
|
I don't think these changes make any sense. A kick for an incorrect version will be executed one way or another due to the return of nullptr. Regarding the fact that clients were marked as entering the game, this does not pose any problem. One way or another, if the player does not take the necessary actions, he will be kicked lower. |
Contributor
Author
No, it won't. This PR fixes precisely that bug. Don't comment if you can't read or understand the code. @Hual Re-added kick calls as per your suggestion, so invalid clients get kicked ASAP. |
Member
|
Syncing raknet here, since it's related. changes are from this PR: openmultiplayer/RakNet#22 |
Hual
previously approved these changes
Apr 3, 2024
AmyrAhmady
previously approved these changes
Apr 4, 2024
ksenonadv
previously approved these changes
Apr 4, 2024
AmyrAhmady
dismissed stale reviews from ksenonadv, Hual, and themself
via
7d65932
AmyrAhmady
approved these changes
Apr 4, 2024
ksenonadv
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.