Skip to content

OADP-8924: Treat missing openshift-apiserver config as no internal registry - #489

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-devfrom
kaovilai:fix-registryinfo-configmap-notfound
Oct 21, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-devfrom
kaovilai:fix-registryinfo-configmap-notfound

Conversation

@kaovilai

@kaovilai kaovilai commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Problem

Backing up a virt-launcher pod fails with:

error executing custom action (groupResource=pods ...): rpc error: code = Unknown desc = configmaps "config" not found

GetRegistryInfo (velero-plugins/common/shared.go) looks for the internal registry hostname in the openshift-apiserver/config ConfigMap on K8s minor > 11, after the openshift namespace imagestream lookup yields nothing. On clusters without that ConfigMap the Get returns NotFound, which was returned as-is. common/backup.go Execute propagates it, and since AppliesTo includes pods, the whole pod backup fails.

When this happens

Both must hold in the cluster where Velero runs: the openshift-apiserver/config ConfigMap is absent, and the openshift namespace imagestream lookup yields no hostname.

  • The ConfigMap is created by cluster-openshift-apiserver-operator on standard OCP. On an HCP (HyperShift) guest no operator runs in the guest, and hypershift creates no such ConfigMap there (the config lives in a ConfigMap named openshift-apiserver in the management cluster's control-plane namespace). Based on reading hypershift and operator code; not yet checked on a live guest.
  • On a default HCP guest the CVO imagestreams exist in openshift and the registry is up, so the imagestream lookup should succeed and the ConfigMap is never read. The bug is expected on a guest where the imagestream lookup comes up empty, most likely with the ImageRegistry capability disabled (or the registry Removed), or on non-OpenShift clusters.
  • On standard OCP with the registry Removed the ConfigMap exists without the hostname key, which the plugin already handles.

The failure is not specific to virtualization: any backup or restore touching the AppliesTo kinds hits the same call.

Fix

On apierrors.IsNotFound, log, cache an empty registry hostname, and return "", nil. This matches the existing handling of a missing docker-registry service on K8s <= 1.11. Other errors are still returned.

Consumers of an empty hostname:

  • imagestreamtag/restore.go guards on len(backupInternalRegistry) > 0.
  • buildconfig/restore.go and util.go (SwapContainerImageRefs) are no-ops or pass the annotation through.
  • imagestream/backup.go passes it to imagecopy.CopyLocalImageStreamImages, which skips internal-registry images when the hostname is empty. On such a cluster, internal images are not copied during backup. This is the same outcome as for any cluster where the registry cannot be discovered, and it is preferable to failing every pod backup.

common/restore.go has the same call and is fixed by the same change.

Testing

New TestGetRegistryInfoConfigMap in velero-plugins/common/shared_test.go uses an httptest server as the API (no production refactor needed) and calls GetRegistryInfo twice per case:

  • 404: ("", nil), cached, one API request
  • 200 with hostname: hostname returned, cached, one API request
  • 500: error returned, not cached, two API requests

The 404 case fails on unfixed oadp-dev and passes with the fix. go test ./... passes except build and imagestream, which need /usr/local/kubebuilder/bin/etcd (envtest) and fail for that reason in this environment.

Not yet verified on a live HCP guest cluster.

Workaround until this lands

Use the hotfix image, which contains this fix. Multi-arch (linux/amd64 + linux/arm64), built from 6020363, for testing:

quay.io/tkaovila/openshift-velero-plugin:fix-registryinfo-configmap-notfound

To check whether a cluster is exposed (both must hold: the ConfigMap is absent and the openshift namespace has no imagestreams):

oc get cm -n openshift-apiserver config
oc get is -n openshift

Backports to oadp-X.Y branches to follow after this lands.

Notes

  • spec.backupImages: false on the DataProtectionApplication does not avoid this bug. In oadp-operator it only omits the OPENSHIFT_IMAGESTREAM_BACKUP env var on the Velero container (internal/controller/velero.go), skips registry secret handling, and drops the BSL prefix requirement. In this plugin that env var is read only by imagecopy/imagestream.go. The registry lookup is not gated by it: common/backup.go:66 and common/restore.go:66 call GetRegistryInfo for every item the common plugin handles, so the NotFound is still returned. No DPA setting is known to avoid the failing call.
  • Only a NotFound on the ConfigMap is tolerated. Other errors (403, an empty or malformed config.yaml, transient 5xx) still fail the item; client-go retries a 5xx only when the response carries Retry-After. Making those non-fatal would also change common/restore.go and is left out of this PR.

Note

Responses generated with Claude (model: Claude Sonnet 5.5)

Summary by CodeRabbit

  • Bug Fixes
    • Environments without an internal container registry are now handled gracefully, rather than treating the missing registry configuration as an error. Registry information remains cached when available, while other configuration retrieval errors continue to be reported. This improves reliability for deployments where an internal registry is not configured.

GetRegistryInfo returned the NotFound error from the openshift-apiserver/config
ConfigMap Get. Clusters without that ConfigMap (e.g. HCP guest clusters, where
openshift-apiserver runs on the management cluster) then failed every
backup/restore item action that calls GetRegistryInfo, such as pods:

  error executing custom action (groupResource=pods ...): rpc error:
  code = Unknown desc = configmaps "config" not found

On NotFound, cache and return an empty registry hostname with no error, matching
the existing handling of a missing docker-registry service on K8s <= 1.11. Other
errors are still returned.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Co-Authored-By: Claude Code (model: Claude Sonnet 5.5) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2026
@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 57996fe2-4452-421a-9ea8-ff4cd8b39b8f
📥 Commits

Reviewing files that changed from the base of the PR and between 0c44b57 and 6020363.

📒 Files selected for processing: 2
  • velero-plugins/common/shared.go
  • velero-plugins/common/shared_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

GetRegistryInfo now treats a missing openshift-apiserver/config ConfigMap as an absent internal registry. It caches and returns an empty registry host without an error. Other retrieval errors still return an error.

Changes

Registry ConfigMap handling

Layer / File(s) Summary
Handle registry ConfigMap responses
velero-plugins/common/shared.go, velero-plugins/common/shared_test.go
GetRegistryInfo logs and caches an empty registry host when the ConfigMap is missing. Tests cover missing, successful, and failed retrievals, including cache state and ConfigMap request counts.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 60203

Backup and restore actions no longer fail when the openshift-apiserver config ConfigMap is absent. The change is small and tested, and no merge-blocking risk was found. Behavior on a live HCP guest cluster has not been verified.

Pre-merge checks: Passed 14 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 14 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names Passed The added test uses standard Go testing, not Ginkgo. TestGetRegistryInfoConfigMap and its t.Run names are fixed string literals. They contain no pod names, timestamps, UUIDs, node names, random na…
Test Structure And Quality Passed PASS: The pull request adds a standard Go testing test, not Ginkgo code. shared_test.go contains no It, BeforeEach, AfterEach, Eventually, or Consistently blocks. It uses subtests for re…
Microshift Test Compatibility Passed The pull request adds TestGetRegistryInfoConfigMap as a standard Go testing test in velero-plugins/common/shared_test.go. It does not add Ginkgo It, Describe, Context, or When e2e tests.…
Single Node Openshift (Sno) Test Compatibility Passed PASS: The pull request adds a standard Go testing.T unit test, not a Ginkgo e2e test. It uses an httptest server and does not assume multiple nodes, HA behavior, node roles, scheduling, or failove…
Topology-Aware Scheduling Compatibility Passed PASS: The pull request changes only registry lookup logic in velero-plugins/common/shared.go and its tests in shared_test.go. It adds no deployment manifests, controllers, replicas, affinity, topo…
Ote Binary Stdout Contract Passed The pull request changes registry lookup logic and adds a unit test. It does not modify an OTE binary entrypoint or process-level suite setup, and the added logrus call is inside GetRegistryInfo rathe…
Ipv6 And Disconnected Network Test Compatibility Passed PASS. The pull request adds a standard Go testing unit test, not a Ginkgo e2e test. It uses an in-process httptest.NewServer and a cluster-internal registry hostname. The diff contains no hardcode…
No-Weak-Crypto Passed The pull request changes only ConfigMap handling and related tests. The reviewed diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom cryptography, or non-constant-time secret comp…
Container-Privileges Passed The pull request changes only velero-plugins/common/shared.go and shared_test.go. It adds no container or Kubernetes manifest fields such as privileged, hostPID, hostNetwork, hostIPC, `SYS…
No-Sensitive-Data-In-Logs Passed The pull request adds one production log message with a fixed description: the ConfigMap was not found and no internal registry exists. It does not include a hostname, token, password, API key, PII, s…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: treating a missing openshift-apiserver ConfigMap as no internal registry.
Full details: Stable And Deterministic Test Names

Explanation

The added test uses standard Go testing, not Ginkgo. TestGetRegistryInfoConfigMap and its t.Run names are fixed string literals. They contain no pod names, timestamps, UUIDs, node names, random namespaces, IP addresses, or other run-dependent values.

Full details: Test Structure And Quality

Explanation

PASS: The pull request adds a standard Go testing test, not Ginkgo code. shared_test.go contains no It, BeforeEach, AfterEach, Eventually, or Consistently blocks. It uses subtests for related registry-response cases, defers httptest.Server and client-config cleanup, creates no cluster resources, and uses bounded direct calls with diagnostic t.Fatalf messages.

Full details: Microshift Test Compatibility

Explanation

The pull request adds TestGetRegistryInfoConfigMap as a standard Go testing test in velero-plugins/common/shared_test.go. It does not add Ginkgo It, Describe, Context, or When e2e tests. Therefore, the MicroShift API and feature checks do not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds a standard Go testing.T unit test, not a Ginkgo e2e test. It uses an httptest server and does not assume multiple nodes, HA behavior, node roles, scheduling, or failover. The production change adds no test.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only registry lookup logic in velero-plugins/common/shared.go and its tests in shared_test.go. It adds no deployment manifests, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore it introduces no topology-dependent scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes registry lookup logic and adds a unit test. It does not modify an OTE binary entrypoint or process-level suite setup, and the added logrus call is inside GetRegistryInfo rather than main or suite setup. No explicit OTE stdout-contract violation is introduced.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS. The pull request adds a standard Go testing unit test, not a Ginkgo e2e test. It uses an in-process httptest.NewServer and a cluster-internal registry hostname. The diff contains no hardcoded IPv4 address, IPv4-only parsing, public endpoint, external download, or public DNS dependency.

Full details: No-Weak-Crypto

Explanation

The pull request changes only ConfigMap handling and related tests. The reviewed diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom cryptography, or non-constant-time secret comparison.

Full details: Container-Privileges

Explanation

The pull request changes only velero-plugins/common/shared.go and shared_test.go. It adds no container or Kubernetes manifest fields such as privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, runAsUser: 0, or allowPrivilegeEscalation: true.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request adds one production log message with a fixed description: the ConfigMap was not found and no internal registry exists. It does not include a hostname, token, password, API key, PII, session ID, or customer data. The added test logs only generic failure details and does not expose sensitive values.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2026
@kaovilai

Copy link
Copy Markdown
Member Author

/cherry-pick oadp-1.6
/cherry-pick oadp-1.5

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.5, oadp-1.6 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick oadp-1.6
/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai kaovilai changed the title Treat missing openshift-apiserver config as no internal registry OADP-8924: Treat missing openshift-apiserver config as no internal registry Oct 15, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 15, 2026 •

Copy link
Copy Markdown

@kaovilai: This pull request references OADP-8924 which is a valid jira issue.

Details

In response to this:

Problem

Backing up a virt-launcher pod fails with:

error executing custom action (groupResource=pods ...): rpc error: code = Unknown desc = configmaps "config" not found

GetRegistryInfo (velero-plugins/common/shared.go) looks for the internal registry hostname in the openshift-apiserver/config ConfigMap on K8s minor > 11, after the openshift namespace imagestream lookup yields nothing. On clusters without that ConfigMap (suspected: HCP guest clusters, where openshift-apiserver runs on the management cluster, or clusters with no built-in registry) the Get returns NotFound, which was returned as-is. common/backup.go Execute propagates it, and since AppliesTo includes pods, the whole pod backup fails.

Fix

On apierrors.IsNotFound, log, cache an empty registry hostname, and return "", nil. This matches the existing handling of a missing docker-registry service on K8s <= 1.11. Other errors are still returned.

An empty registry is safe for consumers: imagestreamtag/restore.go guards on len(backupInternalRegistry) > 0, imagestream/backup.go only logs it, and buildconfig/restore.go/util.go just pass the annotation through. common/restore.go has the same call and is fixed by the same change.

Testing

New TestGetRegistryInfoConfigMap in velero-plugins/common/shared_test.go uses an httptest server as the API (no production refactor needed) and calls GetRegistryInfo twice per case:

  • 404: ("", nil), cached, one API request
  • 200 with hostname: hostname returned, cached, one API request
  • 500: error returned, not cached, two API requests

The 404 case fails on unfixed oadp-dev and passes with the fix. go test ./... passes except build and imagestream, which need /usr/local/kubebuilder/bin/etcd (envtest) and fail for that reason in this environment.

Not yet verified on a live HCP guest cluster.

Backports to oadp-X.Y branches to follow after this lands.

[!Note]
Responses generated with Claude (model: Claude Sonnet 5.5)

Summary by CodeRabbit

  • Bug Fixes
  • Environments without an internal container registry are now handled gracefully, rather than treating the missing registry configuration as an error. Registry information remains cached when available, while other configuration retrieval errors continue to be reported. This improves reliability for deployments where an internal registry is not configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
kaovilai marked this pull request as ready for review October 15, 2026 15:45
Copilot AI balanced review requested due to automatic review settings October 15, 2026 15:45
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved registry discovery can silently omit local image contents from otherwise successful backups.

1 open finding
What changed in this PR

This PR prevents missing API-server configuration from failing pod backups by treating ConfigMap NotFound responses as an empty internal registry hostname.

Changes:

  • Cache an empty hostname on NotFound while preserving other errors.
  • Add HTTP-backed tests for missing configuration, successful discovery, errors, and caching.
File Description
velero-plugins/​common/​shared.go Handle missing registry configuration without returning an error.
velero-plugins/​common/​shared_test.go Test registry lookup results and caching behavior.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread velero-plugins/common/shared.go Resolved
@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@redhat-chai-bot redhat-chai-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: OADP-8924 — Downstream consumer safety analysis

I've traced every downstream consumer of GetRegistryInfo() to verify the PR's claim that an empty registry hostname is safe. The claim holds — the fix is correct and safe.

Fix analysis

The production change is minimal and correct: apierrors.IsNotFound(err) on the ConfigMap GET, then log, cache empty, return ("", nil). This mirrors the existing K8s ≤ 1.11 pattern (docker-registry service not found → same graceful empty return). Other errors (500, 403, network) are still propagated — good.

Bonus coverage: A ConfigMap GET against a nonexistent namespace (e.g. openshift-apiserver namespace absent entirely on HCP guest) also returns NotFound, so apierrors.IsNotFound catches that scenario too.

Downstream consumer verification

I audited every file that reads BackupRegistryHostname / RestoreRegistryHostname or calls GetRegistryInfo():

Consumer Empty registry behavior Safe?
util.go SwapContainerImageRefs if oldRegistry == "" || newRegistry == "" { return } — immediate no-op ✅
imagestreamtag/restore.go localImage := len(backupInternalRegistry) > 0 && ... — guards on non-empty ✅
imagestream/backup.go Only logs internalRegistry, no error on empty ✅
imagestream/restore.go GetSrcAndDestRegistryInfo reads annotation — empty means no local images identified ✅
deployment/restore.go Calls SwapContainerImageRefs (guarded) ✅
pod/restore.go Calls SwapContainerImageRefs (guarded) ✅
daemonset/restore.go Calls SwapContainerImageRefs (guarded) ✅
statefulset/restore.go Calls SwapContainerImageRefs (guarded) ✅
cronjob/restore.go Calls SwapContainerImageRefs (guarded) ✅
job/restore.go Calls SwapContainerImageRefs (guarded) ✅
replicaset/restore.go Calls SwapContainerImageRefs (guarded) ✅
replicationcontroller/restore.go Calls SwapContainerImageRefs (guarded) ✅
deploymentconfig/restore.go Calls SwapContainerImageRefs (guarded) ✅
buildconfig/restore.go Passes annotation through to UpdateCommonSpec ✅
common/restore.go Also calls GetRegistryInfo() — fixed by same shared function ✅

The SwapContainerImageRefs guard at util.go:92-94 is the ultimate safety net — every resource restore plugin flows through it.

Test quality

The test is well-structured:

  • Uses httptest server — no production refactoring needed, no real API dependency
  • Covers the three key paths: 404 (fix target), 200 (existing happy path), 500 (error passthrough)
  • Verifies caching semantics (404/200 cache → 1 API call; 500 doesn't cache → 2 API calls)
  • Properly sets serverVersion to Minor=30 to reach the ConfigMap code path
  • Returns empty ImageStream list to ensure Step 1 falls through
  • Resets registryInfo between subtests

One scenario to note (not a blocker)

If the internal registry IS configured on an HCP guest but ImageStreams in openshift are somehow unpopulated (Step 1 misses it), this fix means we silently skip image copy instead of crashing. That's strictly better than the current behavior (crash the whole backup), and it's a pre-existing discovery gap — not something this PR introduces.

CI passes (images ✅, unit-test ✅).


AI-generated. Review for accuracy.

@jparrill

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2026

@weshayutin weshayutin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

redhat-chai-bot added a commit to redhat-chai-bot/oadp-operator that referenced this pull request Oct 20, 2026
Add a test case to the external HCP backup/restore suite that deploys a
workload pod on the guest cluster and includes the guest namespace in
the Velero backup.  This exercises the openshift-velero-plugin
GetRegistryInfo() code path that fails on HCP guest clusters where the
openshift-apiserver/config ConfigMap is absent (fixed in
openshift/openshift-velero-plugin#489).

Changes:
- hcp_backup_restore_suite_test.go: add AdditionalBackupNamespaces
  field to HCPBackupRestoreCase and wire it into runHCPBackupAndRestore
  so tests can include extra namespaces in the backup.
- hcp_external_cluster_backup_restore_suite_test.go: add new test
  "HCP external cluster guest pod backup test (OADP-8924)" with
  helpers to create and validate a test pod on the guest cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
redhat-chai-bot added a commit to redhat-chai-bot/oadp-operator that referenced this pull request Oct 20, 2026
Add a test case to the external HCP backup/restore suite that deploys a
workload pod on the guest cluster and includes the guest namespace in
the Velero backup.  This exercises the openshift-velero-plugin
GetRegistryInfo() code path that fails on HCP guest clusters where the
openshift-apiserver/config ConfigMap is absent (fixed in
openshift/openshift-velero-plugin#489).

Changes:
- hcp_backup_restore_suite_test.go: add AdditionalBackupNamespaces
  field to HCPBackupRestoreCase and wire it into runHCPBackupAndRestore
  so tests can include extra namespaces in the backup.
- hcp_external_cluster_backup_restore_suite_test.go: add new test
  "HCP external cluster guest pod backup test (OADP-8924)" with
  helpers to create and validate a test pod on the guest cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
redhat-chai-bot added a commit to redhat-chai-bot/oadp-operator that referenced this pull request Oct 20, 2026
Add a test case to the external HCP backup/restore suite that deploys a
workload pod on the guest cluster and includes the guest namespace in
the Velero backup.  This exercises the openshift-velero-plugin
GetRegistryInfo() code path that fails on HCP guest clusters where the
openshift-apiserver/config ConfigMap is absent (fixed in
openshift/openshift-velero-plugin#489).

Changes:
- hcp_backup_restore_suite_test.go: add AdditionalBackupNamespaces
  field to HCPBackupRestoreCase and wire it into runHCPBackupAndRestore
  so tests can include extra namespaces in the backup.
- hcp_external_cluster_backup_restore_suite_test.go: add new test
  "HCP external cluster guest pod backup test (OADP-8924)" with
  helpers to create and validate a test pod on the guest cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
redhat-chai-bot added a commit to redhat-chai-bot/oadp-operator that referenced this pull request Oct 20, 2026
Add a test case to the external HCP backup/restore suite that deploys a
workload pod on the guest cluster and includes the guest namespace in
the Velero backup.  This exercises the openshift-velero-plugin
GetRegistryInfo() code path that fails on HCP guest clusters where the
openshift-apiserver/config ConfigMap is absent (fixed in
openshift/openshift-velero-plugin#489).

Changes:
- hcp_backup_restore_suite_test.go: add AdditionalBackupNamespaces
  field to HCPBackupRestoreCase and wire it into runHCPBackupAndRestore
  so tests can include extra namespaces in the backup.
- hcp_external_cluster_backup_restore_suite_test.go: add new test
  "HCP external cluster guest pod backup test (OADP-8924)" with
  helpers to create and validate a test pod on the guest cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
redhat-chai-bot added a commit to redhat-chai-bot/oadp-operator that referenced this pull request Oct 20, 2026
Add a test case to the external HCP backup/restore suite that deploys a
workload pod on the guest cluster and includes the guest namespace in
the Velero backup.  This exercises the openshift-velero-plugin
GetRegistryInfo() code path that fails on HCP guest clusters where the
openshift-apiserver/config ConfigMap is absent (fixed in
openshift/openshift-velero-plugin#489).

Changes:
- hcp_backup_restore_suite_test.go: add AdditionalBackupNamespaces
  field to HCPBackupRestoreCase and wire it into runHCPBackupAndRestore
  so tests can include extra namespaces in the backup.
- hcp_external_cluster_backup_restore_suite_test.go: add new test
  "HCP external cluster guest pod backup test (OADP-8924)" with
  helpers to create and validate a test pod on the guest cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kaovilai

Copy link
Copy Markdown
Member Author

github dumb. closes this due to openshift/release#87392 merging as if it was an issue being fixed.

/reopen

@openshift-ci openshift-ci Bot reopened this Oct 21, 2026
@openshift-ci

openshift-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown

@kaovilai: Reopened this PR.

Details

In response to this:

github dumb. closes this due to openshift/release#87392 merging as if it was an issue being fixed.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4db7736 into openshift:oadp-dev Oct 21, 2026
4 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@kaovilai: new pull request created: #498

Details

In response to this:

/cherry-pick oadp-1.6
/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@kaovilai: new pull request created: #499

Details

In response to this:

/cherry-pick oadp-1.6
/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants