Repository navigation
[oadp-1.5] OADP-8924: Treat missing openshift-apiserver config as no internal registry - #499
Conversation
GetRegistryInfo returned the NotFound error from the openshift-apiserver/config ConfigMap Get. Clusters without that ConfigMap (e.g. HCP guest clusters, where openshift-apiserver runs on the management cluster) then failed every backup/restore item action that calls GetRegistryInfo, such as pods: error executing custom action (groupResource=pods ...): rpc error: code = Unknown desc = configmaps "config" not found On NotFound, cache and return an empty registry hostname with no error, matching the existing handling of a missing docker-registry service on K8s <= 1.11. Other errors are still returned. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-Authored-By: Claude Code (model: Claude Sonnet 5.5) <noreply@anthropic.com>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OADP-8924 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/lgtm |
|
/lgtm |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Validated this oadp-1.5 backport on a live HCP guest: ROSA HCP, OCP 4.21.40, OADP 1.5.8. The fix works. On base ( Findings from the live guest, beyond what #489 reasoned from code:
Caveat: the missing configmap was real, but I induced the empty-imagestream condition. I set samples to
Details
Note Responses generated with Claude (model: Claude Opus 5.5) |
This is an automated cherry-pick of #489
/assign kaovilai