[fix] Added handling for no connnection in DeviceConnection.get_working_connection#720
Merged
Merged
Conversation
…ng_connection DeviceConnection.get_working_connection did not handle the case when no DeviceConnection object is present for a device. If a device does not have any DeviceConnection, then in the raised NoWorkingDeviceConnectionError exception, the connection attribute will be set to None.
pandafy
force-pushed
the
fix-get-working-device-conn
branch
from
ca00be2 to
9d39bf4
Compare
nemesifier
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceConnection.get_working_connection did not handle the case when no DeviceConnection object is present for a device.
If a device does not have any DeviceConnection, then in the raised NoWorkingDeviceConnectionError exception, the connection attribute will be set to None.