Skip to content

[fix] Added handling for no connnection in DeviceConnection.get_working_connection #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 1 commit into from
Nov 23, 2022
Merged

[fix] Added handling for no connnection in DeviceConnection.get_working_connection #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions openwisp_controller/connection/base/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@ def get_working_connection(
enabled=True,
credentials__connector=connector,
).order_by('-is_working')
# NoWorkingDeviceConnectionError.connection will be
# equal to None if the device has no DeviceConnection.
device_conn = None
for device_conn in qs.iterator():
is_connected = device_conn.connect()
if is_connected:
Expand Down
6 changes: 6 additions & 0 deletions openwisp_controller/connection/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ def test_device_connection_get_working_connection(self, mocked_connect):
org = self._get_org()
device = self._create_device(organization=org)
self._create_config(device=device)

with self.subTest('Test device has no connection object'):
with self.assertRaises(NoWorkingDeviceConnectionError) as error:
conn = DeviceConnection.get_working_connection(device)
self.assertEqual(error.exception.connection, None)

conn1 = self._create_device_connection(
device=device,
credentials=self._create_credentials(organization=org, name='test1'),
Expand Down