fix: handle non-top-level claims when mirroring is disabled#4087
Open
elatt wants to merge 3 commits intoory:masterfrom
Open
fix: handle non-top-level claims when mirroring is disabled#4087elatt wants to merge 3 commits intoory:masterfrom
elatt wants to merge 3 commits intoory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation of the
mirror_top_level_claimsoption (#3563) simply removed theextclaim entirely when mirroring was disabled. However, we have a usecase where we want top level claims to be allowed and excluded from theextclaim but for claims that are not in the top level list, we still want them to be present in theextclaim.Related issue(s)
#3348
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.com) from the maintainers to push
the changes.
works.
Further Comments
I don't believe this should be a breaking change because the original set of tests and implementation didn't address this scenario so it looks like we should be free to add these claims back in.