Skip to content

fix: handle non-top-level claims when mirroring is disabled#4087

Open
elatt wants to merge 3 commits intoory:masterfrom
datarobot-forks:elatt/fix-mirror-top-level-claims
Open

fix: handle non-top-level claims when mirroring is disabled#4087
elatt wants to merge 3 commits intoory:masterfrom
datarobot-forks:elatt/fix-mirror-top-level-claims

Conversation

@elatt
Copy link
Copy Markdown

@elatt elatt commented Mar 26, 2026

The original implementation of the mirror_top_level_claims option (#3563) simply removed the ext claim entirely when mirroring was disabled. However, we have a usecase where we want top level claims to be allowed and excluded from the ext claim but for claims that are not in the top level list, we still want them to be present in the ext claim.

Related issue(s)

#3348

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.com) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

I don't believe this should be a breaking change because the original set of tests and implementation didn't address this scenario so it looks like we should be free to add these claims back in.

@elatt elatt requested review from a team and aeneasr as code owners March 26, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant