Locale json merge #385
Merged
Locale json merge #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some time working with the localizations, I sadly reached the decision to make another refactor. This is caused by the nuisance of specifing namespaces and maintaining multiple files, where it is sometimes not clear where a translation should go. Since the bundle size gains are negiligible with respect to the worse DX, I decided to merge all app related logic into common, keeping only the bulky currencies and categories outside, as well as the homepage.
This is also helpful for setting up tools like i18 ally and webplate, which will be added to the repo soon. This will decouple locale maintenance from regular work and significantly reduce the maintenance burden on me and developers adding new features.
From now on, anyone can update their fixes through the webplate UI and it is not required to add strings for all locales when implementing new features.