feat(Table): update ActionsColumn to use Dropdown next#8629
feat(Table): update ActionsColumn to use Dropdown next#8629nicolethoen merged 8 commits intopatternfly:v5from
Conversation
|
Preview: https://patternfly-react-pr-8629.surge.sh A11y report: https://patternfly-react-pr-8629-a11y.surge.sh |
12773ca to
6d2bee8
Compare
|
Thanks to @jeffpuzzo for helping me debug the handful of build errors that were happening due to next component usage. For next components at least in Table, the full path of Also updated Select and Dropdown next to prevent the component from throwing an error when the optional |
6d2bee8 to
e4ed53e
Compare
|
Rebased. I removed the rebase add of |
|
@jeffpuzzo Pinging you for a review especially of the Wizard components after the rebase, there were several merge conflicts and want to make sure I didn't miss something. |
jpuzz0
left a comment
There was a problem hiding this comment.
Re-reviewed wizard related changes. LGTM
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #8390
ActionsColumnto use Dropdown-next componentspopperPropsto Dropdown-next to allow customization of Popper (includingdirection,position,popperMatchesTriggerWidththat is used byActionsColumn). If this would be better as separately piped props let me know and I can update them. But for now this will allow the greatest flexibility.MenuTogglefor custom toggle