Skip to content

feat(web): the new tab launcher works for the thread on screen, and every workspace keeps a tab - #37375

Open
flamboh wants to merge 14 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-launcher-v2
Open

flamboh wants to merge 14 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-launcher-v2

Conversation

@flamboh

@flamboh flamboh commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Change for the redesign stack, targets layer 6 (#28845).

Important

Needs Maria's review. This reworks the new tab launcher and how blank tabs, "+" and closing behave. It is a proposal for her to accept, change or close.

The new tab launcher was one tall list. It offered surfaces for a thread that was not on screen, so it was unclear what a Terminal or Diff would open for. An empty workspace had no real tab, just bare chrome with the launcher drawn in. And "+" did different things on different panes: a menu on chat panes, something else on surface panes.

Now the launcher always says which thread it works for, and every workspace always holds at least one real tab.

  • Surfaces sit in two columns under "Open for", next to the thread's chip. The chip links to the thread.
  • One pull request row that follows the thread.
  • Side chat moves to the thread menu.
  • No thread in view means no surfaces.
  • An empty workspace starts with a real blank tab.
  • "+" always opens a blank tab, on chat, surface and blank panes alike.
  • Closing never leaves a workspace without a tab: its last tab gives way to a blank tab, and closing that blank tab closes the workspace.
  • A blank tab drops its thread once that thread has nothing left in the workspace.
  • "All pull requests" is the only page row left. It sits under a divider, with no caption. Settings and Usage open as dialogs, so they are gone from the launcher.

Trade-offs

  • A blank tab with no thread can no longer start a Browser or Terminal that is not tied to a thread.
  • The "+" dropdown and its right-click "open beside" menu are gone.
  • A middle workspace holding one blank tab disappears when you leave it.

Not verified in a browser: the pull request row with linked pull requests.

Before / after

Before and after: pressing "+" opened a dropdown and now opens a blank tab; the launcher was one long list and now shows "Open for" with the thread's chip, surfaces in two columns, and "All pull requests" under a divider; an empty workspace had no real tab and now has one "New tab" tab with no surfaces

Closing a workspace's last thread tab, then what is left. Watch the tab row after each close:

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/837ae9b26f718359/closing.mp4

Validation

  • vp run check:changed e14e7e0ba33: format, lint, knip and typecheck pass. 185 of 191 tests pass. The layout tests (layoutModel, layoutActions, Overview, SurfaceHost, ChatHeader) all pass, including new cases for closing and blank tabs.
  • The 6 failures are already on layer 6. The same files fail the same way on a clean checkout of e14e7e0ba33:
    • ChatView.browser.test.tsx: 3 prompt stash tests
    • ChatView.handoffCompaction.browser.test.tsx: cold Claude thread follow-up (timeout)
    • ChatView.modelPick.browser.test.tsx: model pick reaches the server (timeout)
    • DraftHeroHeadline.browser.test.tsx: project picker follows manual sidebar order

Made with Claude Opus 5.5 in Claude Code.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This changes the default workspace and tab-closing experience and adds a line-level lint suppression. Both changes require human review under the repository’s explicit approval requirements.

You can add or adjust custom eligibility rules. Learn more.

@flamboh
flamboh marked this pull request as draft November 15, 2026 22:28
The launcher's 'Open for' line passes its own click handler to the chip, so chat
markdown and composer chips keep their base imports.
Settings and Usage open as dialogs, so the launcher drops them. Its page row
is now "All pull requests", apart from the thread's own pull requests.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant