Repository navigation
feat(web): the new tab launcher works for the thread on screen, and every workspace keeps a tab - #37375
Open
flamboh wants to merge 14 commits into
Open
feat(web): the new tab launcher works for the thread on screen, and every workspace keeps a tab#37375flamboh wants to merge 14 commits into
flamboh wants to merge 14 commits into
Conversation
…er beside its blank tab
Contributor
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This changes the default workspace and tab-closing experience and adds a line-level lint suppression. Both changes require human review under the repository’s explicit approval requirements. You can add or adjust custom eligibility rules. Learn more. |
flamboh
marked this pull request as draft
November 15, 2026 22:28
The launcher's 'Open for' line passes its own click handler to the chip, so chat markdown and composer chips keep their base imports.
Settings and Usage open as dialogs, so the launcher drops them. Its page row is now "All pull requests", apart from the thread's own pull requests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Change for the redesign stack, targets layer 6 (#28845).
Important
Needs Maria's review. This reworks the new tab launcher and how blank tabs, "+" and closing behave. It is a proposal for her to accept, change or close.
The new tab launcher was one tall list. It offered surfaces for a thread that was not on screen, so it was unclear what a Terminal or Diff would open for. An empty workspace had no real tab, just bare chrome with the launcher drawn in. And "+" did different things on different panes: a menu on chat panes, something else on surface panes.
Now the launcher always says which thread it works for, and every workspace always holds at least one real tab.
Trade-offs
Not verified in a browser: the pull request row with linked pull requests.
Before / after
Closing a workspace's last thread tab, then what is left. Watch the tab row after each close:
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/837ae9b26f718359/closing.mp4
Validation
vp run check:changed e14e7e0ba33: format, lint, knip and typecheck pass. 185 of 191 tests pass. The layout tests (layoutModel,layoutActions,Overview,SurfaceHost,ChatHeader) all pass, including new cases for closing and blank tabs.e14e7e0ba33:ChatView.browser.test.tsx: 3 prompt stash testsChatView.handoffCompaction.browser.test.tsx: cold Claude thread follow-up (timeout)ChatView.modelPick.browser.test.tsx: model pick reaches the server (timeout)DraftHeroHeadline.browser.test.tsx: project picker follows manual sidebar orderMade with Claude Opus 5.5 in Claude Code.