Repository navigation
Conversation
…he layout The sidebar's Pull requests button and each thread row's PR badge now drag into the layout the way a thread row does: same drop zones, labels, threshold and Escape. The page lands as its one tab (an open one moves); the badge opens the thread's pull request, or its linked pull requests list, at the drop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
flamboh
marked this pull request as ready for review
November 16, 2026 01:17
This comment has been minimized.
This comment has been minimized.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds drag-to-layout support for the Pull Requests button and thread PR badges using existing PR views. Effects are limited to user-initiated navigation and saved pane arrangement, with existing link preferences preserved. You can add or adjust custom eligibility rules. Learn more. |
flamboh
marked this pull request as draft
November 16, 2026 01:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Change for the redesign stack, targets layer 6 (#28845).
Important
Needs Maria's review.
Problem
A thread row can be dragged from the sidebar into the layout. The Pull Requests button and a thread's pull request badge cannot, so putting those pages beside a chat takes extra steps.
Change
Both are now drag sources, and they drop like a thread row does:
While dragging, a chip follows the pointer. It is the same lifted tab the tab drag shows, with the icon and title the new tab gets: "Pull requests" for either list, and the pull request's state icon with "#123" for one pull request. A plain click still opens the page as before.
The dragged tab now shows its lifted surface too, because both share one element and that surface was not being applied.
Known limits
Note for merging
#37375 also edits the drop check in
LayoutDropZones(apps/web/src/layout/DropZones.tsx). Whichever lands second should refuse a drop into a blank launcher tab only for asource.kind === "tab"whose content is the launcher, and allow every other source kind.Evidence
Dragging the Pull Requests button. Before (base) the same pointer movement does nothing; after, the chip follows the pointer and the drop splits the page beside the chat.
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/39960f1b7b366206/drag-button.mp4
Dragging a thread's pull request badge into the tab row.
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/a18006e598dc9467/drag-badge.mp4
The chip for each of the three sources:
The dragged tab, which shares the chip's element:
Validation
vp test run apps/web/src/layout/layoutDrag.test.ts apps/web/src/layout/SurfaceHost.browser.test.tsx: 8 passed. The drop rules are unit tests; the cases that need the surface sync mounted (a dropped pull request surviving a reload, and a drop that reopens hidden panels) stay in the layout host's browser test.vp run check:changed e6cf9cc54c: format, lint, knip, typecheck, tests and the React compiler check pass.Made with Claude Opus 5.5 in Claude Code (T3 Code).