Check if element has style attribute defined before reading/changing it#343
Merged
pocketjoso merged 2 commits intoMar 28, 2022
Conversation
pocketjoso
reviewed
Mar 27, 2022
Owner
pocketjoso
left a comment
pocketjoso
left a comment
There was a problem hiding this comment.
Just one comment - after that we can merge this. 👍
|
|
||
| // but do that only if elements have their style attribute defined | ||
| // (ref: https://github.com/pocketjoso/penthouse/issues/342) | ||
| if (typeof element.style !== 'undefined') { |
Owner
There was a problem hiding this comment.
to save some computation since this code runs on a hot code path inside a loop (once for each selector in the css) - can you assign this typeof check to a variable and re-use it both in this if condition and in the one on line 35?
|
Any chance of a release with this fix in it? Just hit this exact bug #342. |
Owner
|
Sure - I just published version 2.3.3! |
|
You're awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #342