Skip to content

Check if element has style attribute defined before reading/changing it #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pocketjoso merged 2 commits into from
Mar 28, 2022
Merged

Check if element has style attribute defined before reading/changing it #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15d542
Check if element has a style attribute defined before reading/changin…
lucasrla Mar 27, 2022
3dd7f02
Create a variable to save computations
lucasrla Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/browser-sandbox/pruneNonCriticalSelectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,23 @@ export default function pruneNonCriticalSelectors ({
// temporarily force clear none in order to catch elements that clear previous
// content themselves and who w/o their styles could show up unstyled in above
// the fold content (if they rely on f.e. 'clear:both;' to clear some main content)
var originalClearStyle = element.style.clear || ''
element.style.clear = 'none'

// but do that only if elements have their style attribute defined
// (ref: https://github.com/pocketjoso/penthouse/issues/342)
const isElementStyleDefined = typeof element.style !== 'undefined'
if (isElementStyleDefined) {
var originalClearStyle = element.style.clear || ''
element.style.clear = 'none'
}

var aboveFold = element.getBoundingClientRect().top < h
// cache so we dont have to re-query DOM for this value
isElementAboveFoldCache.set(element, aboveFold)

// set clear style back to what it was
element.style.clear = originalClearStyle
if (isElementStyleDefined) {
// set clear style back to what it was
element.style.clear = originalClearStyle
}

// Should not be needed anymore with Chrome Headless:
// do some monitoring before complete removing the code (below)
Expand Down