bug fix combined-lock-locked issue #10843#11022
Merged
max-sixty merged 1 commit intopydata:mainfrom Jan 4, 2026
Merged
Conversation
Collaborator
|
ref #10843 |
max-sixty
reviewed
Dec 16, 2025
xarray/tests/test_issue_10843.py
Outdated
| @@ -0,0 +1,78 @@ | |||
| """Test for issue #10843: CombinedLock.locked() always returns true.""" | |||
Collaborator
There was a problem hiding this comment.
can we have this as a test in a more idomatic place? ty!
samay2504
force-pushed
the
fix/xarray-10843-combined-lock-locked
branch
from
ab0333a to
6f7885f
Compare
max-sixty
approved these changes
Dec 16, 2025
|
Verified locally. |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jan 28, 2026
- Add missing bug fixes: pydata#11064, pydata#11026, pydata#11022, pydata#11005, pydata#10980, pydata#10788, pydata#11085 - Add missing documentation entries: pydata#10958, pydata#11094, pydata#11080 - Add missing performance entry: pydata#11105 - Add Internal Changes section with pydata#11108 - Fix rST roles: use :py:func:, :py:meth:, :py:class: consistently - Fix missing commas between :issue: and :pull: references - Fix typo in Dataset.identical entry - Fix wrong PR number for coord ordering (11098 -> 11091) - Add missing :pull: reference for arithmetic_compat (pydata#10943) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.