Skip to content

Optimize CFMaskScale decoder.#11105

Merged
dcherian merged 5 commits intopydata:mainfrom
dcherian:opt-masking
Jan 28, 2026
Merged

Optimize CFMaskScale decoder.#11105
dcherian merged 5 commits intopydata:mainfrom
dcherian:opt-masking

Conversation

@dcherian
Copy link
Contributor

Previously we would make at least one, possibly two copies of the data in many cases. Now we always make one copy.

Previously we would make two copies of the data in many cases.
Now we always make one copy.
@dcherian dcherian requested a review from kmuehlbauer January 26, 2026 21:54
Copy link
Contributor

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @dcherian!

@dcherian
Copy link
Contributor Author

@keewis @VeckoTheGecko how do I fix this error: Error: × lock-file not up-to-date with the workspace

@VeckoTheGecko

This comment was marked as outdated.

@VeckoTheGecko
Copy link
Contributor

Try update the Pixi pins to v0.63.2? (there was a problem in v0.63.1 which I think we're running into prefix-dev/pixi#5302 - we install xarray as a source dep, and this does look like it has to do with an 'out of date' lock file)

@dcherian
Copy link
Contributor Author

Thank you!

@dcherian dcherian added the plan to merge Final call for comments label Jan 28, 2026
@dcherian dcherian merged commit 43edfa3 into pydata:main Jan 28, 2026
58 of 76 checks passed
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 28, 2026
- Add missing bug fixes: pydata#11064, pydata#11026, pydata#11022, pydata#11005, pydata#10980, pydata#10788, pydata#11085
- Add missing documentation entries: pydata#10958, pydata#11094, pydata#11080
- Add missing performance entry: pydata#11105
- Add Internal Changes section with pydata#11108
- Fix rST roles: use :py:func:, :py:meth:, :py:class: consistently
- Fix missing commas between :issue: and :pull: references
- Fix typo in Dataset.identical entry
- Fix wrong PR number for coord ordering (11098 -> 11091)
- Add missing :pull: reference for arithmetic_compat (pydata#10943)

Co-authored-by: Claude <noreply@anthropic.com>
@dcherian dcherian deleted the opt-masking branch January 28, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to merge Final call for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants